-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for multiple types of entity cost breakdown
- Loading branch information
1 parent
f3b24a9
commit e3071a0
Showing
19 changed files
with
929 additions
and
623 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@backstage/plugin-cost-insights': minor | ||
| --- | ||
|
|
||
| Add support for multiple types of entity cost breakdown. | ||
|
|
||
| This change is backwards-incompatible with plugin-cost-insights 0.3.x; the `entities` field on Entity returned in product cost queries changed from `Entity[]` to `Record<string, Entity[]`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
plugins/cost-insights/src/components/ProductInsightsCard/ProductEntityDialog.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| /* | ||
| * Copyright 2020 Spotify AB | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { wrapInTestApp } from '@backstage/test-utils'; | ||
| import { ProductEntityDialog } from './ProductEntityDialog'; | ||
| import { render } from '@testing-library/react'; | ||
| import { Entity } from '../../types'; | ||
|
|
||
| const atomicEntity: Entity = { | ||
| id: null, | ||
| aggregation: [0, 0], | ||
| change: { ratio: 0, amount: 0 }, | ||
| entities: {}, | ||
| }; | ||
|
|
||
| const singleBreakdownEntity = { | ||
| ...atomicEntity, | ||
| entities: { | ||
| SKU: [ | ||
| { | ||
| id: 'sku-1', | ||
| aggregation: [0, 0], | ||
| change: { ratio: 0, amount: 0 }, | ||
| entities: {}, | ||
| }, | ||
| { | ||
| id: 'sku-2', | ||
| aggregation: [0, 0], | ||
| change: { ratio: 0, amount: 0 }, | ||
| entities: {}, | ||
| }, | ||
| ] as Entity[], | ||
| }, | ||
| }; | ||
|
|
||
| const multiBreakdownEntity = { | ||
| ...singleBreakdownEntity, | ||
| entities: { | ||
| ...singleBreakdownEntity.entities, | ||
| deployment: [ | ||
| { | ||
| id: 'd-1', | ||
| aggregation: [0, 0], | ||
| change: { ratio: 0, amount: 0 }, | ||
| entities: {}, | ||
| }, | ||
| { | ||
| id: 'd-2', | ||
| aggregation: [0, 0], | ||
| change: { ratio: 0, amount: 0 }, | ||
| entities: {}, | ||
| }, | ||
| ] as Entity[], | ||
| }, | ||
| }; | ||
|
|
||
| describe('<ProductEntityDialog/>', () => { | ||
| it('Should error if no sub-entities exist', () => { | ||
| expect(() => | ||
| render( | ||
| wrapInTestApp( | ||
| <ProductEntityDialog | ||
| open | ||
| entity={atomicEntity} | ||
| onClose={jest.fn()} | ||
| selectedLabel={null} | ||
| setSelectedLabel={jest.fn()} | ||
| />, | ||
| ), | ||
| ), | ||
| ).toThrow(); | ||
| }); | ||
|
|
||
| it('Should not show tabs for a single sub-entity type', () => { | ||
| const { queryByText } = render( | ||
| wrapInTestApp( | ||
| <ProductEntityDialog | ||
| open | ||
| entity={singleBreakdownEntity} | ||
| onClose={jest.fn()} | ||
| selectedLabel={null} | ||
| setSelectedLabel={jest.fn()} | ||
| />, | ||
| ), | ||
| ); | ||
| expect(queryByText('Breakdown by SKU')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('Should show tabs when multiple sub-entity types exist', () => { | ||
| const { getByText } = render( | ||
| wrapInTestApp( | ||
| <ProductEntityDialog | ||
| open | ||
| entity={multiBreakdownEntity} | ||
| onClose={jest.fn()} | ||
| selectedLabel={null} | ||
| setSelectedLabel={jest.fn()} | ||
| />, | ||
| ), | ||
| ); | ||
| expect(getByText('Breakdown by SKU')).toBeInTheDocument(); | ||
| expect(getByText('Breakdown by deployment')).toBeInTheDocument(); | ||
| expect(getByText('sku-1')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('Shows the pre-selected tab, if provided', () => { | ||
| const { getByText } = render( | ||
| wrapInTestApp( | ||
| <ProductEntityDialog | ||
| open | ||
| entity={multiBreakdownEntity} | ||
| onClose={jest.fn()} | ||
| selectedLabel="deployment" | ||
| setSelectedLabel={jest.fn()} | ||
| />, | ||
| ), | ||
| ); | ||
| expect(getByText('d-1')).toBeInTheDocument(); | ||
| }); | ||
| }); |
Oops, something went wrong.