Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk vulnerability [SNYK-JS-AXIOS-6032459] #20942

Closed
github-actions bot opened this issue Nov 2, 2023 · 8 comments
Closed

Snyk vulnerability [SNYK-JS-AXIOS-6032459] #20942

github-actions bot opened this issue Nov 2, 2023 · 8 comments
Labels
good first issue Good for newcomers help wanted Help/Contributions wanted from community members snyk-vulnerability stale

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Affecting Packages/Plugins

Overview

axios is a promise-based HTTP client for the browser and Node.js.

Affected versions of this package are vulnerable to Cross-site Request Forgery (CSRF) due to inserting the X-XSRF-TOKEN header using the secret XSRF-TOKEN cookie value in all requests to any server when the XSRF-TOKEN0 cookie is available, and the withCredentials setting is turned on. If a malicious user manages to obtain this value, it can potentially lead to the XSRF defence mechanism bypass.

Workaround

Users should change the default XSRF-TOKEN cookie name in the Axios configuration and manually include the corresponding header only in the specific places where it's necessary.

Remediation

Upgrade axios to version 1.6.0 or higher.

References

@github-actions github-actions bot added help wanted Help/Contributions wanted from community members snyk-vulnerability labels Nov 2, 2023
@Rugvip
Copy link
Member

Rugvip commented Nov 13, 2023

Appreciate any help with this one. We're treating it as low prio since it doesn't affect us

@benjdlambert benjdlambert added the good first issue Good for newcomers label Nov 17, 2023
@HChenCBRE
Copy link

@Rugvip here is a PR to resolve the axios issue from auth-backend
#21664

@sbarrypoppulo
Copy link
Contributor

axios has been bumped to ^1.0.0 in here. I'll submit a PR to bump the @trendyol-js/openstack-swift-sdk dependency to ^0.0.7 in @backstage/techdocs-node, similar to this.

I'll also poke around the other reported packages depending on older axios and see that I can dig up.

@sbarrypoppulo
Copy link
Contributor

Upgrading @useoptic/optic to ^0.53.5+ should resolve older axios version via the analytics-node dependency being upgraded here - opticdev/optic#2558

Not sure if Renovate should have re-raised a PR - #21543 (likely will when 0.54.0 is released?)

@sbarrypoppulo
Copy link
Contributor

yarn why axios 
├─ @backstage/plugin-opencost@workspace:plugins/opencost
│  └─ axios@npm:1.6.5 (via npm:^1.4.0)
│
├─ @openapitools/openapi-generator-cli@npm:2.9.0
│  └─ axios@npm:1.6.5 (via npm:1.6.5)
│
├─ @swagger-api/apidom-reference@npm:0.92.0
│  └─ axios@npm:1.6.5 (via npm:^1.4.0)
│
├─ @trendyol-js/openstack-swift-sdk@npm:0.0.7
│  └─ axios@npm:1.6.5 (via npm:^1.0.0)
│
├─ analytics-node@npm:6.2.0
│  └─ axios@npm:0.27.2 (via npm:^0.27.2)
│
├─ circleci-api@npm:4.1.4
│  └─ axios@npm:0.21.4 (via npm:^0.21.1)
│
└─ passport-auth0@npm:1.4.4
   └─ axios@npm:1.6.5 (via npm:^1.6.0)

@sbarrypoppulo
Copy link
Contributor

https://github.com/worldturtlemedia/circleci-api seems pretty much unmaintained 😢 Last release ~3 years ago

Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 23, 2024
@camilaibs camilaibs removed the stale label Mar 25, 2024
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Help/Contributions wanted from community members snyk-vulnerability stale
Projects
None yet
Development

No branches or pull requests

5 participants