Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump axios to v1 #8

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

karlhaworth
Copy link
Contributor

@karlhaworth karlhaworth commented Nov 28, 2023

chore: bump axios to v1

addresses CVE-2023-45857 -> axios/axios#6006

All cmds from readme work just fine. Marked as fix as this needs to release.

Bumped typescript due to -> axios/axios#5428 (comment)

@karlhaworth
Copy link
Contributor Author

ping @mertcb for review or guidance on how to refine :)

@karlhaworth
Copy link
Contributor Author

@muratcorlu not sure if you have time. small change

@muratcorlu
Copy link
Contributor

@nemre Can you help for this? Maybe by finding the relevant person to review?

@jrtaylorJH
Copy link

+1 to this due to axios security vuln

@jrtaylorJH
Copy link

@muratcorlu

@muratcorlu
Copy link
Contributor

I don't work at Trendyol anymore and I don't have access for this repository. Last time @Dentrax helped to merge a PR. Can you help for this one as well @Dentrax ?

@Dentrax Dentrax merged commit e9629f4 into Trendyol:master Jan 22, 2024
@Dentrax
Copy link
Member

Dentrax commented Jan 22, 2024

LGTM! Merged.

Thank you for pinging me @muratcorlu and sorry for the long wait - we missed this one. @karlhaworth

FWIW maybe we should create a Dependabot workflow in this project. Filed an issue: #9

cc @mertcb

@Dentrax
Copy link
Member

Dentrax commented Jan 22, 2024

0.0.7 is released - thanks for your contribution!

@sbarrypoppulo
Copy link

Looks like the workflow failed to publish to NPM - https://github.com/Trendyol/openstack-swift-sdk/actions/runs/7616422104/job/20743136912

@Dentrax
Copy link
Member

Dentrax commented Jan 22, 2024

Yep, some permission issue I guess, will check tomorrow.

@karlhaworth
Copy link
Contributor Author

Think it got the same version number? Did I need to manually bump the version?

@muratcorlu
Copy link
Contributor

Apparently version number needs to be increased manually in package.json

@Dentrax
Copy link
Member

Dentrax commented Jan 22, 2024

Ah thank you @muratcorlu. Re-tagged for the new release: https://github.com/Trendyol/openstack-swift-sdk/actions/runs/7616648954/job/20743909803

Sorry - I'm not so familiar with TS.

#11 Is this still needed, @karlhaworth?

@karlhaworth
Copy link
Contributor Author

appears not. thanks

@jrtaylorJH
Copy link

Not seeing it in NPM yet, just some lag with that workflow publishing or did something not finalize properly?

Thanks for the quick response, all

@muratcorlu
Copy link
Contributor

You can see that it's published with v0.0.7 (aka James Bond 😊) https://www.npmjs.com/package/@trendyol-js/openstack-swift-sdk/v/0.0.7

@jrtaylorJH
Copy link

Thank you! Just came through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants