-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump axios to v1 #8
Conversation
ping @mertcb for review or guidance on how to refine :) |
@muratcorlu not sure if you have time. small change |
@nemre Can you help for this? Maybe by finding the relevant person to review? |
+1 to this due to axios security vuln |
LGTM! Merged. Thank you for pinging me @muratcorlu and sorry for the long wait - we missed this one. @karlhaworth FWIW maybe we should create a Dependabot workflow in this project. Filed an issue: #9 cc @mertcb |
0.0.7 is released - thanks for your contribution! |
Looks like the workflow failed to publish to NPM - https://github.com/Trendyol/openstack-swift-sdk/actions/runs/7616422104/job/20743136912 |
Yep, some permission issue I guess, will check tomorrow. |
Think it got the same version number? Did I need to manually bump the version? |
Apparently version number needs to be increased manually in package.json |
Ah thank you @muratcorlu. Re-tagged for the new release: https://github.com/Trendyol/openstack-swift-sdk/actions/runs/7616648954/job/20743909803 Sorry - I'm not so familiar with TS. #11 Is this still needed, @karlhaworth? |
appears not. thanks |
Not seeing it in NPM yet, just some lag with that workflow publishing or did something not finalize properly? Thanks for the quick response, all |
You can see that it's published with v0.0.7 (aka James Bond 😊) https://www.npmjs.com/package/@trendyol-js/openstack-swift-sdk/v/0.0.7 |
Thank you! Just came through. |
chore: bump axios to v1
addresses CVE-2023-45857 -> axios/axios#6006
All cmds from readme work just fine. Marked as
fix
as this needs to release.Bumped
typescript
due to -> axios/axios#5428 (comment)