Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes: Entity name is used instead of value of backstage.io/kubernetes-id annotation #5051

Closed
mclarke47 opened this issue Mar 22, 2021 · 1 comment
Closed

Kubernetes: Entity name is used instead of value of backstage.io/kubernetes-id annotation #5051

mclarke47 opened this issue Mar 22, 2021 · 1 comment
Labels
area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. bug Something isn't working good first issue Good for newcomers help wanted Help/Contributions wanted from community members

Comments

@mclarke47
Copy link
Collaborator

Expected Behavior

The value of the entity annotation backstage.io/kubernetes-id should be used to lookup Kubernetes resources.

Current Behavior

The value of the entity's name is used to to lookup the Kubernetes resources.

Possible Solution

https://github.com/backstage/backstage/blob/master/plugins/kubernetes-backend/src/service/KubernetesFanOutHandler.ts#L61 should be removed and replaced by looking up the annotation value in the entity like https://github.com/backstage/backstage/blob/master/plugins/kubernetes-backend/src/service/KubernetesFanOutHandler.ts#L88 for backstage.io/kubernetes-label-selector
@mclarke47 mclarke47 added bug Something isn't working area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. good first issue Good for newcomers labels Mar 22, 2021
@Rugvip Rugvip added the help wanted Help/Contributions wanted from community members label Mar 22, 2021
benjdlambert added a commit that referenced this issue Mar 30, 2021
@benjdlambert
Merge pull request #5053 from shoebsd31/master
bd90c8f 
#5051 entity name updated
@benjdlambert
Copy link
Member

Believe it was fixed in #5053?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. bug Something isn't working good first issue Good for newcomers help wanted Help/Contributions wanted from community members
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjdlambert @Rugvip @mclarke47