Reviewers Wanted! #8294
Comments
|
I would like to handover my assignments to someone at SDA SE, for example @dschwank, I will probably not be able to handle it in the future 😞 But I don't think he will get a notification this way? |
|
@benjdlambert I will also very likely not be able to do it. Especially the |
|
@benjdlambert @jhaals is is possible to assign a GitHub group that is part of another organisation? (I think that would be the preferred solution for the SDA SE instead of assigning individuals.) |
|
@petergrau I believe it should be possible, if not we could create a group in the Backstage Org instead. Do you have one that we could try with maybe and see what our options are? |
highly doubt an outside group will be possible, you can't even ping teams from outside the org you're currently interacting in. |
|
@benjdlambert @jhaals @dhenneke @Fox32 Sure, happy to contribute & help you out with some reviews 🥳
A group would be awesome, so we can share the ownership within the SDA SE! |
|
Yep @timja is right, doesn't look like that is possible. @backstage/maintainers what do you think about the option of creating some additional org groups for use cases like this or should we stick to list of users? |
|
That should be ok. Maybe make some naming pattern for them - |
Have you tested this out? According to the GitHub docs you need write access, https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Saying this as someone with experience with CODEOWNERS in a large mono repo 😂 |
that would work for us. |
Setup scaffolder-backend-module-yeoman CODEOWNERS following backstage#8294
Setup scaffolder-backend-module-yeoman CODEOWNERS following backstage#8294
Setup scaffolder-backend-module-yeoman CODEOWNERS following backstage#8294 Signed-off-by: @pawelmitka <pawel.mitka@brainly.com>
|
@petergrau sent over an invite, we'll see if I can let you invite the rest or if we're gonna need a list x) |
|
@petergrau Alright, gave you access to manage the team, let me know if that's enough or if we need to handle the organization level access too |
@Rugvip Looks like that I can add members but only if they are part of the org already. Should I give you a list of people? |
|
@petergrau yep, please do, haven't found any better way to handle it right now short of setting up automation ._. |
@Rugvip here you go:
|
|
Closing this issue now. Help and review support is still welcome of course ❤️ |
This is a very late response to issue #8294 which requested reviewers on certain plugins. Also added an entry for `cost-insights-*` since there is now a `cost-insights-common` package. Signed-off-by: Andrew Thauer <athauer@wealthsimple.com>
|
@jhaals can you please add @Hennnnes to our team (https://github.com/orgs/backstage/teams/sda-se-reviewers) - thank you! |
|
@petergrau invited! |
|
Hey, |
We are looking for your help reviewing incoming pull requests to community plugins.
There is a constant stream of contributions to our community plugins and we are looking for contributors to help us out reviewing these changes. If you have created, made contributions to, or used an existing plugin, then you can help the community by reviewing incoming changes!
I’m not an experienced reviewer
No one is perfect at code reviews but more eyes on pull requests lead to less bugs, mistakes and in the end better code! Your stamp of approval will count as another signal for the maintainers ultimately merging the pull request. Pre-approved pull requests are much more likely to be reviewed and merged quicker.
What if I don’t have enough time?
No worries. Your life isn’t going to change being a code owner, the primary difference is that you will get notified about changes by Github automatically instead of having to manually scan for incoming PRs.
Does it mean I can merge code if I think it looks good?
Not initially as we want to make sure that everything runs smoothly and cannot be abused.
Suggested Codeowners
We’ve run through the plugins that we currently have in the monorepo and picked a few key contributors that we think would be a great fit for Codeowners and be the first point of contact when it comes to changes to the plugins. Of course, we’re not going to force you to commit to doing it, but it would be great if you think there’s someone else that you could nominate instead 🙏
If your name isn’t listed in the suggestions, but still feel like you would be a great fit for reviewing code changes in a particular plugin then feel free to skip to the next section and raise a PR adding yourself! :)
allureapi-docsapp-backendauth-backendazure-devopsazure-devops-backendazure-devops-commonbadgesbadges-backendbazaarbazaar-backendbitrisecatalogcatalog-backendcatalog-backend-module-ldapcatalog-backend-module-msgraphcatalog-graphcatalog-graphqlcatalog-importcatalog-reactcirclecicloudbuildcode-coveragecode-coverage-backendconfig-schemacost-insightsexploreexplore-reactfirehydrantfossagcp-projectsgit-release-managergithub-actionsgithub-deploymentsgitops-profilesgraphiqlgraphql-backendilertjenkinsjenkins-backendkafkakafka-backendkuberneteskubernetes-backendkubernetes-commonlighthousenewrelicorgpagerdutypermission-backendpermission-commonpermission-nodeproxy-backendrollbarrollbar-backendscaffolderscaffolder-backend-module-railsscaffolder-backend-module-yeomanscaffolder-backend-module-cookiecuttersearch-backend-module-elasticsearchsearch-backend-module-pgsentrysentry-backendshortcutssonarqubesplunk-on-calltech-insights-backendtech-insights-backend-module-jsonfctech-insights-commontech-insights-nodetech-radartodouser-settingsxcmetricsHow do I add myself?
Simple, raise a PR against
.github/CODEOWNERSadding yourself to an existing plugin in the list or create a new line for the plugin of your interest. It’s important to have@backstage/reviewersas the first entry in the list of owners and then your username./plugins/plugin_name @backstage/reviewers @usernameThe text was updated successfully, but these errors were encountered: