-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MySquads #10026
Added MySquads #10026
Conversation
🦋 Changeset detectedLatest commit: c9d59ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@freben, I put this in the Org plugin as that seemed to make the most logic sense to me. I'm open to moving it though, would be pretty easy. Also, for the test of a user with multiple groups I could not find a way to get at the |
ce5dea0
to
1a35824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just a nit about the naming? 🙏
1a35824
to
0e19ada
Compare
Ready for another review, please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just small nits
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
c9d59ee
to
f00ebdf
Compare
Changed Packages
|
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
I could swear it said I should have a changeset for the example-app, I'll take that out then |
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
plugins/org/src/components/MyGroupsSidebarItem/MyGroupsSidebarItem.test.tsx
Show resolved
Hide resolved
plugins/org/src/components/MyGroupsSidebarItem/MyGroupsSidebarItem.test.tsx
Show resolved
Hide resolved
plugins/org/src/components/MyGroupsSidebarItem/MyGroupsSidebarItem.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
plugins/org/src/components/MyGroupsSidebarItem/MyGroupsSidebarItem.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
@freben thanks for your patience with me on this one, have some things to take away and learn better. I think I have this PR in a state where it's ready to merge now though |
Signed-off-by: Johan Haals <johan.haals@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience with this one @awanlin
I took the liberty to fix commit a small fix for a mismatch in single/double quotes.
Going to ship this once it goes green
Thanks @benjdlambert @freben and @jhaals for your reviews and helping me through with this. 🚀 |
Signed-off-by: Andre Wanlin awanlin@rapidrtc.com
Hey, I just made a Pull Request!
Introduced a new MySquads SidebarItem that links to one or more groups based on the logged in user's membership.
To use MySquads you'll need to add it to your
Root.tsx
like this:Single Squad:
Multiple Squads:
(MySquads uses the
metadata.title
and if that is not present then uses themetadata.name
this is why Team D is shown as "team-d")Closes #8678
✔️ Checklist
Signed-off-by
line in the message. (more info)