Implement code changes as suggested by analysis tools

[AaronvDiepen]

Hey, I just made a Pull Request!

For our university course Software Architecture we are analysing various open source systems and after running various code analysis tools on the Backstage project we have detected a few minor mistakes that might give unexpected results.

The changes (and their explanations) are:

• double non-null assertion operators
  a non-null variable can not suddenly turn into null, most likely the writer thought he was doing boolean conversion
• unexpected awaits for non-promise values
  might give the illusion that a function returns a promise while it does not

The tool used to find these changes was deepsource.io.

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[changeset-bot]

🦋 Changeset detected

Latest commit: 4521e67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 53 packages

Name	Type
@backstage/cli	Patch
@backstage/config-loader	Patch
@backstage/core-app-api	Patch
@backstage/plugin-catalog-backend-module-bitbucket	Patch
@backstage/plugin-tech-insights-backend	Patch
@backstage/app-defaults	Patch
example-app	Patch
@backstage/backend-common	Patch
@backstage/backend-tasks	Patch
@backstage/backend-test-utils	Patch
example-backend	Patch
@backstage/dev-utils	Patch
techdocs-cli-embedded-app	Patch
@techdocs/cli	Patch
@backstage/test-utils	Patch
@backstage/plugin-airbrake-backend	Patch
@backstage/plugin-airbrake	Patch
@backstage/plugin-app-backend	Patch
@backstage/plugin-auth-backend	Patch
@backstage/plugin-auth-node	Patch
@backstage/plugin-azure-devops-backend	Patch
@backstage/plugin-badges-backend	Patch
@backstage/plugin-bazaar-backend	Patch
@backstage/plugin-bazaar	Patch
@backstage/plugin-catalog-backend-module-aws	Patch
@backstage/plugin-catalog-backend-module-azure	Patch
@backstage/plugin-catalog-backend-module-github	Patch
@backstage/plugin-catalog-backend-module-gitlab	Patch
@backstage/plugin-catalog-backend-module-ldap	Patch
@backstage/plugin-catalog-backend-module-msgraph	Patch
@backstage/plugin-catalog-backend	Patch
@backstage/plugin-code-coverage-backend	Patch
@backstage/plugin-graphql-backend	Patch
@backstage/plugin-jenkins-backend	Patch
@backstage/plugin-kafka-backend	Patch
@backstage/plugin-kubernetes-backend	Patch
@backstage/plugin-periskop-backend	Patch
@backstage/plugin-permission-backend	Patch
@backstage/plugin-permission-node	Patch
@backstage/plugin-proxy-backend	Patch
@backstage/plugin-rollbar-backend	Patch
@backstage/plugin-scaffolder-backend-module-cookiecutter	Patch
@backstage/plugin-scaffolder-backend-module-rails	Patch
@backstage/plugin-scaffolder-backend	Patch
@backstage/plugin-search-backend-module-pg	Patch
@backstage/plugin-search-backend	Patch
@backstage/plugin-tech-insights-backend-module-jsonfc	Patch
@backstage/plugin-tech-insights-node	Patch
@backstage/plugin-techdocs-backend	Patch
@backstage/plugin-techdocs-node	Patch
@backstage/plugin-todo-backend	Patch
@backstage/plugin-scaffolder-backend-module-yeoman	Patch
@backstage/techdocs-common	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[AaronvDiepen]

Some jobs seem to have failed due to server connection errors, is this due to my code changes or was the github <-> server connection failing?

[freben]

Makes sense :)

[suuus]

Hey @AaronvDiepen, congrats on your first merged PR 🎉 Nice work 👍 Please let me know if we can be helpful in any way.