Added emptyContent to properties of Catalog Table #14003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: irma12 <irma@roadie.io>
Changed Packages
|
Signed-off-by: irma12 <irma@roadie.io>
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If you are the author and the PR has been closed, feel free to re-open the PR and continue the contribution! |
Signed-off-by: irma12 <irma@roadie.io>
Rugvip
requested changes
Oct 17, 2022
Comment on lines
60
to
64
| empty: { | ||
| padding: theme.spacing(2), | ||
| display: 'flex', | ||
| justifyContent: 'center', | ||
| }, |
There was a problem hiding this comment.
I wonder if this styling is perhaps a bit too opinionated, should we leave it to the content instead? Especially since it's not possible to override
There was a problem hiding this comment.
Yeah, agree it is too strict. Removed it :)
Signed-off-by: irma12 <irma@roadie.io>
Signed-off-by: irma12 <irma@roadie.io>
|
Thank you for contributing during Hacktoberfest 🍂! You can claim the Backstage Hacktoberfest Holopin at https://bck.st/hacktoberfest-holopin 🙌🏻 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: irma12 irma@roadie.io
Hey, I just made a Pull Request!
Currently we cannot customise empty content, add customised message, component or similar, when there are not entities loaded in Catalog. Think we probably can pass this prop so it is usable in a same way as in other tables,
✔️ Checklist
Signed-off-byline in the message. (more info)