Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Systems or other component types to be shown on the Explore Page #15381

Merged
merged 28 commits into from Apr 4, 2023
Merged

Allow Systems or other component types to be shown on the Explore Page #15381

merged 28 commits into from Apr 4, 2023

Conversation

sblausten
Copy link
Contributor

@sblausten sblausten commented Dec 21, 2022 •
edited

Signed-off-by: sblausten sam@roadie.io

Hey, I just made a Pull Request!

  • Adds generic Explore tab for any entity type on the Explore page
  • Refactor existing to use it.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@sblausten
Add generic Explore tab for entities and refactor existing to use it;…
f9ea944 
… Add Systems to default page

Signed-off-by: sblausten <sam@roadie.io>
@sblausten sblausten requested review from a team as code owners December 21, 2022 17:55
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 21, 2022 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-explore plugins/explore patch v0.4.2-next.2

@sblausten
Make changeset a minor
8465e98 
Signed-off-by: sblausten <sam@roadie.io>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022 •
edited

Uffizzi Ephemeral Environment deployment-19602

☁️ https://app.uffizzi.com/github.com/backstage/backstage/pull/15381

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@sblausten
Fix export and typo
a651c48 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Export more stuff for use
18537fe 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
remove duplicate exports
3373cc3 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Fix test and update api-report
7d308d6 
Signed-off-by: sblausten <sam@roadie.io>
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Dec 29, 2022
@Rugvip Rugvip removed the stale label Jan 2, 2023
@sblausten
Fix test
b3e2136 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Merge branch 'master' into systems-tab
967a2e9
@sblausten sblausten requested review from andrewthauer, alde and a team as code owners January 3, 2023 14:48
@github-actions github-actions bot added area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area labels Jan 3, 2023
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@sblausten
Build api reports
6a5dc55 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Revert "Build api reports"
268f58a 
This reverts commit 6a5dc55.

Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Api report
26b4bbd 
Signed-off-by: sblausten <sam@roadie.io>
@github-actions github-actions bot removed area:scaffolder Everything and all things related to the scaffolder project area area:catalog Related to the Catalog Project Area labels Jan 3, 2023
@sblausten
Change to patch changeset
7137f8f 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Remove systems tab from defaults
2ad6372 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Ammend readme
d12f28c 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Rename prop
bda537d 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Update api report
1940139 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten sblausten requested review from Rugvip and andrewthauer and removed request for Rugvip and andrewthauer March 17, 2023 14:48
@sblausten
deps
2216940 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Add test
e604552 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Fix test
6666963 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Copy link
Contributor Author

@Rugvip is there anything else needed for this PR to get merged?

@sblausten sblausten changed the title Add Systems tab to Explore Page and allow other kinds to be shown Allow Systems or other component types to be shown on the Explore Page Mar 23, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 30, 2023
@efenner-cambia
Copy link
Contributor

not stale

@github-actions github-actions bot removed the stale label Mar 31, 2023
Rugvip
Rugvip requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks good! Just a couple of small tweaks

plugins/explore/README.md Outdated Show resolved Hide resolved
.changeset/itchy-kiwis-unite.md Outdated Show resolved Hide resolved
plugins/explore/src/components/DomainCard/DomainCard.test.tsx Outdated Show resolved Hide resolved
sblausten and others added 4 commits April 4, 2023 17:48
@sblausten @Rugvip
Update .changeset/itchy-kiwis-unite.md
a580e4a 
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Sam Blausten <sam@roadie.io>
@sblausten @Rugvip
Update plugins/explore/README.md
f40e571 
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Sam Blausten <sam@roadie.io>
@sblausten
Remove extra licencing comments
fab17a4 
Signed-off-by: sblausten <sam@roadie.io>
@sblausten
Component name update
6b2a5fe 
Signed-off-by: sblausten <sam@roadie.io>
Rugvip
Rugvip approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

Let's :shipit: 🎉

@Rugvip Rugvip merged commit 5b2e705 into backstage:master Apr 4, 2023
26 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.13.0 release, scheduled for Tue, 18 Apr 2023.

@sblausten sblausten deleted the systems-tab branch April 5, 2023 08:09
@awanlin awanlin mentioned this pull request Jan 2, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewthauer andrewthauer andrewthauer left review comments

@Rugvip Rugvip Rugvip approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

Assignees

@Rugvip Rugvip

@agentbellnorm agentbellnorm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sblausten @Rugvip @efenner-cambia @andrewthauer @agentbellnorm