Microsoft Calendar Plugin #16101

Abhay-soni-developer · 2023-02-01T07:26:06Z

🔖 Summary

the request for this feature is here : #16001

the plugin will give a card component where the user can see his daily calendar schedule, and switch between different calendars, if a meeting URL is mentioned, the user can directly click on it to join a meeting and cancelled meetings are stroked.

hovering over any event will pop over a card showing you the list of people invited with a badge over each showing their responses.

microsoft-calendar-plugin-demo.mp4

✌️ Context

Creating a plugin to achieve the following feature:

Select the menu to switch between calendars.
card showing the list of events on a selected date and of the selected calendar
hovering over the event will pop over a card showing the event summary message, and list of attendees.
attendee's chips will have a badge over them symbolizing their responses
green --> accepted
red --> declined
nothing --> not responded yet

backstage-goalie · 2023-02-01T07:26:30Z

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
example-app	packages/app	none	`v0.2.80-next.2`
@backstage/plugin-microsoft-calendar	plugins/microsoft-calendar	minor	`v0.0.0`

github-actions · 2023-02-01T07:38:29Z

Uffizzi Preview deployment-13038 was deleted.

benjdlambert

Hey 👋 thanks for this!

Looking pretty good code wise, just a few comments to clear up.

Would also be pretty good to write some test for these components that you've got too. I see a lot of test-id being used, but no tests :(

plugins/microsoft-calendar/README.md

plugins/microsoft-calendar/src/hooks/useEventsQuery.ts

plugins/microsoft-calendar/src/components/util.ts

Abhay-soni-developer · 2023-02-01T12:48:36Z

@benjdlambert i have done changes according to feedback, are we good to integrate this.

benjdlambert · 2023-02-01T12:51:09Z

Would also be pretty good to write some test for these components that you've got too. I see a lot of test-id being used, but no tests :(

Would it be possible to write some tests for this? Just some simple ones that just render the components and make sure that the expected content is there? It's pretty hard for us to accept other contributions to this plugin when there's no test that ensure that the plugin still works :)

benjdlambert · 2023-02-01T12:52:30Z

Another separate question - where did you get the svg icons? Are they open source and licensed properly that we can copy the contents here? This change will also need a changeset too which you can generate using yarn changeset.

Abhay-soni-developer · 2023-02-01T18:39:36Z

Another separate question - where did you get the svg icons? Are they open source and licensed properly that we can copy the contents here? This change will also need a changeset too which you can generate using yarn changeset.

the icons are from https://www.svgrepo.com which provide open-licensed SVG vectors.
https://www.svgrepo.com/svg/475024/webcam. --> webcam
https://www.svgrepo.com/svg/263516/calendar ---> calendar
these icons are under CC0 license.
@benjdlambert

i will add the changeset right away

Abhay-soni-developer · 2023-02-02T04:00:25Z

Would it be possible to write some tests for this? Just some simple ones that just render the components and make sure that the expected content is there? It's pretty hard for us to accept other contributions to this plugin when there's no test that ensure that the plugin still works :)

i have made changes in dev folder and ensured that there is a working demo available for every user, just one command away. test case's i will try to contribute in the future or will raise it as an issue so if someone is eager can pick it up early.

@benjdlambert
everything is set , plugin is working too. what do you say can we get this integrated ?

awanlin

Really cool contribution, this is something we might add to our homepage in the future, many thanks @Abhay-soni-developer.

Just left some comments about the documentation

awanlin · 2023-02-02T12:46:09Z

.changeset/rotten-birds-build.md

+'@backstage/plugin-microsoft-calendar': patch
+---
+
+created new plugin @backstage/plugin-microsoft-calendar and added it to plugins directory


It would be really great to include how to use it here as this changeset will get used as the release notes. For those upgrading theres a good chance this will be the way they learn about this plugin first.

@Abhay-soni-developer this comment still stands I believe

awanlin · 2023-02-02T12:49:38Z

plugins/microsoft-calendar/README.md

@@ -0,0 +1,19 @@
+# microsoft-calendar


We could probably improve this a lot so that people won't run into issues using this. It would be great to have step by step instructions as to how to install - the yarn add command for the package, where does this get added, etc.

Also, looking over the code it assumes Azure AD auth has been setup, it would be good to include information about that here even if it just a link to the main documentation on this topic. Without this information the calendar won't work and people will log issues about it or simply not use the plugin, which would be a shame as it's pretty awesome!

Here's an example you can use to help for the installation instructions: https://github.com/backstage/backstage/tree/master/plugins/azure-devops

And here's the docs for the Azure auth: https://backstage.io/docs/auth/microsoft/provider

ok will update readme accordingly and push

requested changes done @awanlin @benjdlambert are we good to integrate this?

backstage-goalie · 2023-02-06T07:06:34Z

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

benjdlambert

Hey @Abhay-soni-developer! 👋

Some more comments here, but i think we're getting close!

benjdlambert · 2023-02-06T12:09:24Z

.changeset/rotten-birds-build.md

+'@backstage/plugin-microsoft-calendar': patch
+---
+
+created new plugin @backstage/plugin-microsoft-calendar and added it to plugins directory


@Abhay-soni-developer this comment still stands I believe

benjdlambert · 2023-02-06T12:09:30Z

.changeset/rotten-birds-build.md

+---
+
+created new plugin @backstage/plugin-microsoft-calendar and added it to plugins directory
+updated example-app homepage to show microsoft-calendar widget.


Can remove this part.

I have changed the changeset, if it should be anything else, please let me know and elaborate on what do we need to write here in case of a new plugin.

.github/CODEOWNERS

.changeset/rotten-birds-build.md

plugins/microsoft-calendar/src/components/CalendarCard.tsx

plugins/microsoft-calendar/src/components/CalendarEventPopoverContent.tsx

plugins/microsoft-calendar/src/routes.ts

plugins/microsoft-calendar/src/plugin.ts

benjdlambert · 2023-02-06T12:17:44Z

plugins/microsoft-calendar/src/api/client.ts

+    return response.json() as Promise<T>;
+  }
+
+  public async getCalendars(params?: any): Promise<MicrosoftCalendar[]> {


Can we type params better here?

params will do, they are query path param, or please suggest something better.

I mean the any type. Can we type those?

ok, removing this as we do not need any query paramters in this request

Abhay-soni-developer · 2023-02-07T04:39:04Z

@benjdlambert i have done the changes that u asked for, please have a look.

benjdlambert

Just a few small nits, and you will need to rebase the branch in order to fix the merge conflict in the CODEOWNERS file.

This comment too: #16101 (comment)

plugins/microsoft-calendar/src/components/CalendarEventPopoverContent.tsx

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Signed-off-by: blam <ben@blam.sh>

Abhay-soni-developer · 2023-02-09T05:19:39Z

hey @benjdlambert , i can see that you have made the required changes, is there anything from my side left to do , or we are ready to merge this one.

benjdlambert · 2023-02-09T08:40:03Z

Thanks for the effort and the hard work! 🙏

github-actions · 2023-02-09T08:40:27Z

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.11.0 release, scheduled for Tue, 14 Feb 2023.

Abhay-soni-developer · 2023-02-09T09:35:14Z

@benjdlambert @awanlin for your support and appreciations.

Abhay-soni-developer requested review from a team and backstage-service as code owners February 1, 2023 07:26

backstage-goalie bot assigned Rugvip and samiramkr Feb 1, 2023

This was referenced Feb 1, 2023

🔌 Plugin: microsoft-calendar #16001

Closed

plugin-microsoft-calendar added #16060

Closed

benjdlambert requested changes Feb 1, 2023

View reviewed changes

plugins/microsoft-calendar/README.md Outdated Show resolved Hide resolved

plugins/microsoft-calendar/src/hooks/useEventsQuery.ts Outdated Show resolved Hide resolved

plugins/microsoft-calendar/src/components/util.ts Outdated Show resolved Hide resolved

benjdlambert assigned benjdlambert and unassigned Rugvip Feb 1, 2023

Abhay-soni-developer requested a review from a team as a code owner February 2, 2023 03:54

awanlin requested changes Feb 2, 2023

View reviewed changes

benjdlambert changed the title ~~Develop/microsoft calendar~~ Microsoft Calendar Plugin Feb 2, 2023

Abhay-soni-developer requested a review from a team as a code owner February 6, 2023 06:59

Abhay-soni-developer requested a review from Rugvip February 6, 2023 06:59

Abhay-soni-developer force-pushed the develop/microsoft-calendar branch from fcb078a to 48a0a14 Compare February 6, 2023 07:52

benjdlambert requested changes Feb 6, 2023

View reviewed changes

benjdlambert requested changes Feb 7, 2023

View reviewed changes

plugins/microsoft-calendar/src/components/CalendarEventPopoverContent.tsx Outdated Show resolved Hide resolved

Abhay-soni-developer added 4 commits February 8, 2023 16:11

added new plugin: microsoft-calendar

9fafe68

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

readme modified

6dcc785

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

changes according to feedback

910f6ab

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

added changeset and dev

4441237

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

Abhay-soni-developer and others added 11 commits February 8, 2023 16:11

updated changeset

97e2f07

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

readme fixed

384febd

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

readme modified

3cf71bd

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

readme modified

6d0eb9e

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

feedback changes incorporated

5e7293f

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

changeset modified

7a3559a

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

changeset modified

695b71c

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

updated component name

915aba8

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

removed param from getCalendar function paramters

95510bc

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>

chore: codeowners fix

593ea81

Signed-off-by: blam <ben@blam.sh>

chore: fixing changeset

f2beeee

Signed-off-by: blam <ben@blam.sh>

benjdlambert force-pushed the develop/microsoft-calendar branch from bd148ba to f2beeee Compare February 8, 2023 15:15

benjdlambert added 3 commits February 8, 2023 16:19

chore: fix changeset

9ae00e8

Signed-off-by: blam <ben@blam.sh>

chore: fixing api-reports

8ed1c3b

Signed-off-by: blam <ben@blam.sh>

chore: fixing readme and vale

d3a25fd

Signed-off-by: blam <ben@blam.sh>

benjdlambert approved these changes Feb 9, 2023

View reviewed changes

benjdlambert merged commit 780ce04 into backstage:master Feb 9, 2023

benjdlambert mentioned this pull request Feb 14, 2023

Version Packages #16240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft Calendar Plugin #16101

Microsoft Calendar Plugin #16101

Abhay-soni-developer commented Feb 1, 2023

backstage-goalie bot commented Feb 1, 2023 •

edited

Loading

github-actions bot commented Feb 1, 2023 •

edited

Loading

benjdlambert left a comment

Abhay-soni-developer commented Feb 1, 2023

benjdlambert commented Feb 1, 2023

benjdlambert commented Feb 1, 2023

Abhay-soni-developer commented Feb 1, 2023 •

edited

Loading

Abhay-soni-developer commented Feb 2, 2023

awanlin left a comment

awanlin Feb 2, 2023

benjdlambert Feb 6, 2023

awanlin Feb 2, 2023

awanlin Feb 2, 2023

Abhay-soni-developer Feb 2, 2023

Abhay-soni-developer Feb 6, 2023

backstage-goalie bot commented Feb 6, 2023

benjdlambert left a comment

benjdlambert Feb 6, 2023

benjdlambert Feb 6, 2023

Abhay-soni-developer Feb 7, 2023

benjdlambert Feb 6, 2023

Abhay-soni-developer Feb 6, 2023 •

edited

Loading

benjdlambert Feb 7, 2023

Abhay-soni-developer Feb 8, 2023

Abhay-soni-developer commented Feb 7, 2023

benjdlambert left a comment •

edited

Loading

Abhay-soni-developer commented Feb 9, 2023

benjdlambert commented Feb 9, 2023

github-actions bot commented Feb 9, 2023

Abhay-soni-developer commented Feb 9, 2023

Microsoft Calendar Plugin #16101

Microsoft Calendar Plugin #16101

Conversation

Abhay-soni-developer commented Feb 1, 2023

🔖 Summary

✌️ Context

backstage-goalie bot commented Feb 1, 2023 • edited Loading

Changed Packages

github-actions bot commented Feb 1, 2023 • edited Loading

benjdlambert left a comment

Choose a reason for hiding this comment

Abhay-soni-developer commented Feb 1, 2023

benjdlambert commented Feb 1, 2023

benjdlambert commented Feb 1, 2023

Abhay-soni-developer commented Feb 1, 2023 • edited Loading

Abhay-soni-developer commented Feb 2, 2023

awanlin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

backstage-goalie bot commented Feb 6, 2023

benjdlambert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Abhay-soni-developer Feb 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Abhay-soni-developer commented Feb 7, 2023

benjdlambert left a comment • edited Loading

Choose a reason for hiding this comment

Abhay-soni-developer commented Feb 9, 2023

benjdlambert commented Feb 9, 2023

github-actions bot commented Feb 9, 2023

Abhay-soni-developer commented Feb 9, 2023

backstage-goalie bot commented Feb 1, 2023 •

edited

Loading

github-actions bot commented Feb 1, 2023 •

edited

Loading

Abhay-soni-developer commented Feb 1, 2023 •

edited

Loading

Abhay-soni-developer Feb 6, 2023 •

edited

Loading

benjdlambert left a comment •

edited

Loading