Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Allow Kubernetes Proxy endpoint to support write operations #16117

Merged
merged 3 commits into from Feb 2, 2023

Conversation

RubenV-dev
Copy link
Contributor

Hey, I just made a Pull Request!

Bug Fix that allows Kubernetes Proxy endpoint to support write operations. Fix resolves #16018. Details on the bug were described in bug-report

Changes also allow the proxy to accept content type other than json now. Unit test was added for this.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-kubernetes-backend plugins/kubernetes-backend patch v0.9.3-next.1

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Uffizzi Preview deployment-13107 was deleted.

@jamieklassen jamieklassen mentioned this pull request Feb 1, 2023
5 tasks
Ruben Vallejo added 3 commits February 1, 2023 15:06
Signed-off-by: Ruben Vallejo <rvallejo@gmail.com>
Signed-off-by: Ruben Vallejo <rvallejo@gmail.com>
Signed-off-by: Ruben Vallejo <rvallejo@gmail.com>
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@freben freben merged commit bf31057 into backstage:master Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.11.0 release, scheduled for Tue, 14 Feb 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: kubernetes-backend proxy doesn't forward request body
4 participants