Fix for plugin entity validation: using stated location for the value rather then default #16409
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
2 tasks
ivangonzalezacuna
suggested changes
Feb 17, 2023
plugins/entity-validation/src/components/EntityValidationPage/EntityValidationPage.tsx
Outdated
Show resolved
Hide resolved
plugins/entity-validation/src/components/EntityValidationPage/EntityValidationPage.tsx
Show resolved
Hide resolved
|
Thanks @ivangonzalezacuna for getting back to me so soon with good feedback! I'll get to this tomorrow. |
2 tasks
…an default location Fixes backstage#16406 Signed-off-by: Mark David Avery <mark@webark.cc>
webark
force-pushed
the
fix/updates-to-entity-validation-plugin
branch
from
9a5cb59
to
47d2466
Compare
|
Uffizzi Preview |
ivangonzalezacuna
approved these changes
Feb 22, 2023
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16406
Hey, I just made a Pull Request!
Using the locationUrl from the set state.
Also added some basic style updates and fixed the button deprecation.
✔️ Checklist
Signed-off-byline in the message. (more info)