Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some improvements to the group profile card #16878

Closed
wants to merge 10 commits into from
Closed

some improvements to the group profile card #16878

wants to merge 10 commits into from

Conversation

punkle
Copy link
Contributor

@punkle punkle commented Mar 15, 2023 •
edited

Hey, I just made a Pull Request!

some improvements to the group profile card:

  • The card title will now allow the use of the entity.metadata.title. Now it will either use the profile.displayName, metadata.title, and then the entity name which ever comes first. Previously it did not use the title.
  • The group profile card also now has an optional setting to enable a peek ahead popover which shows the details of the parent and child groups.
  • The entity ref link/s now allow an optional prop to enable the peek ahead popover.

Entity title used as the header of the card:
image

Peek ahead on the parent groups:
image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@punkle
some improvements to the group profile card
c19ae62 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle punkle requested review from a team as code owners March 15, 2023 15:41
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Mar 15, 2023
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Mar 15, 2023 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react patch v1.4.1-next.0
@backstage/plugin-org plugins/org patch v0.6.7-next.0

@punkle
fix typo
a657664 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle
api reports
31a2d08 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited

Uffizzi Preview deployment-20006 was deleted.

@punkle
Fix targetting of peek ahead popover
c8363c5 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@Edje-C
Copy link
Collaborator

Edje-C commented Mar 15, 2023

Hi
Please include screenshots and a more detailed description of your changes.

@punkle
add stories for new group card and entity links
f144580 
Also make the peek ahead on the group card opt in.

Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle
Copy link
Contributor Author

punkle commented Mar 16, 2023

@Edje-C I added storybook items and added screenshots.

@punkle
api reports
a7ac9c2 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle
Copy link
Contributor Author

punkle commented Mar 16, 2023

I dont think the failure is related to my change.

@punkle
Copy link
Contributor Author

punkle commented Mar 16, 2023

Anything I can do to help with this one?

Edje-C
Edje-C reviewed Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@Edje-C Edje-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not looking to accept PRs, especially UI changes, without some discussion on the need /broader desire for such updates first. Is this work the product of an issue or conversation?

.changeset/large-humans-listen.md Outdated Show resolved Hide resolved
plugins/catalog-react/src/components/EntityRefLink/EntityRefLink.tsx Outdated Show resolved Hide resolved
plugins/catalog-react/src/components/EntityRefLink/EntityRefLinks.tsx Outdated Show resolved Hide resolved
plugins/catalog-react/src/components/EntityRefLink/FetchedEntityRefLinks.tsx Outdated Show resolved Hide resolved
@punkle
Copy link
Contributor Author

punkle commented Mar 20, 2023

closes #16961

@punkle
Copy link
Contributor Author

punkle commented Mar 20, 2023

closes #16962

@freben freben mentioned this pull request Mar 20, 2023
Closed
2 tasks
@punkle
Merge branch 'master' of github.com:backstage/backstage into RoadieHQ…
451f991 
…-use-title-on-group-card
@punkle
addressing code review comments
2979035 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle
Copy link
Contributor Author

punkle commented Mar 21, 2023 •
edited

@Edje-C I hadnt created issues. Ive created them and linked them #16961 and #16962. Im happy to discuss the needs around this.

@punkle punkle requested review from Edje-C and removed request for benjdlambert March 21, 2023 15:42
@Edje-C
Copy link
Collaborator

Edje-C commented Mar 22, 2023

Hi, we're discussing internally how we want to handle EntityPeekAheadPopover usage. I'll get back to you with any updates.

@punkle
Copy link
Contributor Author

punkle commented Mar 22, 2023

Thanks @Edje-C in the meantime Ive created a second pull request that isolates the less controversial parts of this pull request #17014

@Edje-C
Copy link
Collaborator

Edje-C commented Mar 22, 2023

Awesome 😂
Thank you so much!

@punkle
Merge branch 'master' into use-title-on-group-card
7449759 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle
remove duplication
3507ee7 
Signed-off-by: Brian Fletcher <brian@roadie.io>
@punkle
Copy link
Contributor Author

punkle commented Mar 23, 2023

@Edje-C It would be great to hear an update about the discussions when they take place? Also I am curious, when you say internal, what do you mean?

@Edje-C
Copy link
Collaborator

Edje-C commented Mar 23, 2023 •
edited

@Edje-C It would be great to hear an update about the discussions when they take place? Also I am curious, when you say internal, what do you mean?

"Internally" as in "amongst maintainers".
The discussion has been that this seems like another reason to take a look at getting some composability patterns in place because essentially that's the best way to solve this. So we'll be bringing that conversation up in the SIG.
#16876

We're looking at proposing some middle ground to solve for this specific use case in the mean time though, so we'll be back with that sometime soon.

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 30, 2023
@punkle
Copy link
Contributor Author

punkle commented Mar 30, 2023

not stale

@github-actions github-actions bot removed the stale label Mar 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 6, 2023
@punkle
Copy link
Contributor Author

punkle commented Apr 11, 2023

not stale

@github-actions github-actions bot removed the stale label Apr 11, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 18, 2023
@Edje-C
Copy link
Collaborator

Edje-C commented Apr 18, 2023

Hello
An update: @freben is working on an in depth solution to the issue you're trying to solve here. It was discussed it in the SIG today and when the PRFC is out, we'll tag you directly for feedback.

@github-actions github-actions bot removed the stale label Apr 18, 2023
@punkle
Copy link
Contributor Author

punkle commented Apr 19, 2023

ok, Ill close this in the meantime.

@punkle punkle closed this Apr 19, 2023
@Edje-C
Copy link
Collaborator

Edje-C commented Apr 19, 2023 •
edited

Cool 🤘🏾 I should've mentioned this but here's a link to what was discussed about his approach
https://docs.google.com/document/d/1xg57CDfX2R5jTGbbWANzifm2szEb664kuTwfEEvKgZU/edit#bookmark=id.t2dm0zwlfhqb

@freben freben mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edje-C Edje-C Awaiting requested review from Edje-C

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@punkle @Edje-C