Tech Insights: When multiple fact retrivers are used for a check and only one returns a given fact

[webark]

Hey, I just made a Pull Request!

This is to address the comment raised in #8516 (comment) and support the use case of

RetrieverA pulls facts and integrates with SystemA, RetrieverB pulls facts and integrates with SystemB. Both output myFact, but RetrieverA only ones that involve SystemA, and RetrieverB SystemB.

Then we can run a check like

  {
    id: 'myCheck',
    type: JSON_RULE_ENGINE_CHECK_TYPE,
    name: 'My Check',
    description: 'All my checks',
    factIds: ['RetrieverA', 'RetrieverB'],
    rule: {
      conditions: {
        all: [
          {
            fact: 'myFact',
            operator: 'equal',
            value: 'cool',
          },
        ],
      },
    },
  }

And it will pass even though RetrieverA and RetrieverB do not have the same facts

pinging @Xantier and @wejendorp

✔️ Checklist

• [x ] A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• [x ] Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• [x ] All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-tech-insights-backend-module-jsonfc	plugins/tech-insights-backend-module-jsonfc	patch	v0.1.28-next.0

[github-actions]

Uffizzi Preview deployment-19219 was deleted.

[Xantier]

Could you add a test case and documentation about the order of facts that are used when two of them with the same identifier are passed in.

Other than that it looks like test cases cover failure cases already so this should be good to go

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[webark]

Aaahh!!! no no no. I was just going to get back to it today. Shoo away stale bot!!

[webark]

@Xantier Let me know if this behavior, documentation, and test coverage fits with what you expect.

[Xantier]

LGTM

[jhaals]

Thanks!

[github-actions]

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.13.0 release, scheduled for Tue, 18 Apr 2023.