[cli]: Use temporary folder for plugin creation to be able to clean up easy #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freben
reviewed
Mar 5, 2020
| process.stdout.write(chalk.green(` Cleaning up ${chalk.cyan(id)}`)); | ||
| try { | ||
| fs.rmdirSync(tempDir, { recursive: true }); | ||
| process.stdout.write(chalk.green(MARKER_SUCCESS)); |
There was a problem hiding this comment.
i am still not entirely clear on why it sometimes is console.log and sometimes process.stdout.write (and why not process.stderr.write for errors)
There was a problem hiding this comment.
The reason is that it's cumbersome to remove a newline in console.log()
| } catch (e) { | ||
| process.stdout.write(chalk.red(` ✗\n`)); | ||
| process.stdout.write(chalk.red(MARKER_FAILURE)); |
There was a problem hiding this comment.
the markers already have colors applied right? this goes for all of the usages below ...
…into eide/cli-atomic
|
|
|
🚢 |
stefanalund
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create all files and run all commands in a temp folder, and then atomically move it to it's final destination if everything succeeded. If not, remove the temp directory and all the files in it.