Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Overflow plugin support for PAT authentication #17157

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

cmdkeen
Copy link
Contributor

@cmdkeen cmdkeen commented Mar 29, 2023

Hey, I just made a Pull Request!

Fixes #15770 by adding support for the new PAT authentication for Stack Overflow as per docs.

Deliberately keeping as a minor change - I've not bumped the default API version number and added a new optional parameter. This is because it isn't clear whether the API key approach is still required for other Stack Overflow integrations.

My first PR against Backstage - great documentation but apologies in advance if I've missed anything!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Chris Hawkins <cmdkeen@users.noreply.github.com>
Signed-off-by: Chris Hawkins <cmdkeen@users.noreply.github.com>
Signed-off-by: Chris Hawkins <cmdkeen@users.noreply.github.com>
@cmdkeen cmdkeen requested a review from a team as a code owner March 29, 2023 16:59
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Mar 29, 2023

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-stack-overflow-backend plugins/stack-overflow-backend minor v0.1.13-next.2

Signed-off-by: Chris <cmdkeen@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

Uffizzi Preview deployment-22121 was deleted.

Signed-off-by: Chris <cmdkeen@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 5, 2023
@github-actions github-actions bot closed this Apr 10, 2023
@cmdkeen
Copy link
Contributor Author

cmdkeen commented Apr 11, 2023

Morning! Can this be re-opened, it should still be valid.

@emmaindal are you able to help with this?

@emmaindal emmaindal reopened this Apr 13, 2023
@emmaindal
Copy link
Member

Hello @cmdkeen thanks a lot for opening this PR, I'll review it!

@github-actions github-actions bot removed the stale label Apr 13, 2023
Copy link
Member

@emmaindal emmaindal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, just one small comment before we can get this merged! And sorry for slow response here, we really appreciate your contribution!

plugins/stack-overflow-backend/README.md Show resolved Hide resolved
Signed-off-by: Chris Hawkins <cmdkeen@users.noreply.github.com>
Signed-off-by: Chris Hawkins <cmdkeen@users.noreply.github.com>
@cmdkeen
Copy link
Contributor Author

cmdkeen commented Apr 13, 2023

Thanks for taking a look @emmaindal - that should be the config fixed and also clarified that the new URL is different for Teams

@cmdkeen cmdkeen requested a review from emmaindal April 14, 2023 09:02
@emmaindal emmaindal merged commit edb4c54 into backstage:master Apr 14, 2023
18 checks passed
@github-actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.13.0 release, scheduled for Tue, 18 Apr 2023.

@cmdkeen cmdkeen deleted the cmdkeen/stackoverflow-pat branch April 14, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: StackOverflow plugin will cease to work
2 participants