Show aggregate users under groups

[wss-rbunning]

Hey, I just made a Pull Request!

This PR adds a toggle switch to the members card, allowing you to toggle between showing direct members and aggregated members of a group. Aggregated users is recursive and handles duplicated users and child groups.

This addresses feature request #16959

Before:

After:

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage/plugin-org	plugins/org	patch	v0.6.8-next.1

[ahhhndre]

@wss-rbunning, is this opt in? As in we won’t see the switch at all if we don’t enable it.

[wss-rbunning]

@ahhhndre As it is right now, the switch is not opt-in and will always be visible. It does, however, default to the off position when the page loads, showing only direct members like before.

[awanlin]

@ahhhndre As it is right now, the switch is not opt-in and will always be visible. It does, however, default to the off position when the page loads, showing only direct members like before.

The general practice is to make these types of things Opt-In. Doing it this way people can choose to have it visible versus it being force upon them. Should be a pretty easy thing to implement. Can we please change that?

(Sorry if this is confusing, I am Ahhhndre I just wanted to follow up on this when I saw it on my phone before I forgot and it got merged in)

[wss-rbunning]

@awanlin Absolutely! I will work on making this opt-in.

[awanlin]

Thanks for this contribution @wss-rbunning, please don't take my comments about making this opt-in to seem like it's not wanted. I know that this is something the Community will be happy to have once it's merged in and released 🚀

Overall this looks good to me, left a few comments

[wss-rbunning]

@awanlin I fully understand the reason for wanting to have it be opt-in and I appreciate the feedback. I have pushed changes that should address your feedback items. Please let me know if there is any other feedback or suggestions you would like me to address 👍.

[awanlin]

LGTM! 🚀

[wss-rbunning]

@awanlin:
@jtreher brought this to my attention: With my current implementation of the switch it loads the aggregated users regardless of whether or not the switch is requested through the prop or flipped on.

With how it is now, it loads the aggregated users in the background, not delaying the page load while this happens. If the switch is flipped to "Aggregate Users" before all aggregate users are done loading, no additional users will be displayed until it is finished.

I am going to change this so that it will only run the logic to get aggregated users if the "show the switch" prop is set (so it isn't doing a lot of extra stuff that someone isn't asking for). Do we want to show a loading bar if the switch is flipped and aggregate users are loading?

[awanlin]

Sounds good to me @wss-rbunning, I think showing a progress bar would be good. How do they deal with that for the Ownership Card? They do something very similar. We don't use it though so I don't remember if it has a progress bar or not.

[github-actions]

Uffizzi Preview deployment-23952 was deleted.

[wss-rbunning]

@awanlin It looks like in the Ownership Card they have a separate "ownership grid" component that is a child of the card itself and does not contain the toggle switch. This grid shows a loading bar when it is loading members.

I have pushed changes with my suggestions. Here is the new behavior:

• When the toggle switch is not enabled, the MembersCard will not bother to load descendant members.
• The existing overall loading bar displayed when loading members on the MemebersCard is still used. It is, however, only used when loading direct members. The loading of descendant members is still asynchronous and does not delay rendering the page or direct members. If the user does flip the switch over to aggregate members before it is done enumerating descendant members, a loading bar will be displayed in place of members until it is finished.

[Rugvip]

Thank you, looks good! 👍

Just a couple of nits

[Rugvip]

Nice, thank you! 😁

Just a tiny think that I'll tweak and then good to

[github-actions]

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.14.0 release, scheduled for Tue, 16 May 2023.