use undici in place of node-fetch #17632
Conversation
The purpose of this patch is to attempt to fix an error that is appearing in the scaffolder fetch:plain:file action. It is throwing this error: `InternalServerError: stream is not readable` Signed-off-by: Brian Fletcher <brian@roadie.io>
Changed Packages
|
Signed-off-by: Brian Fletcher <brian@roadie.io>
| @@ -22,7 +22,7 @@ import { | |||
| ScmIntegrations, | |||
| } from '@backstage/integration'; | |||
| import { RestEndpointMethodTypes } from '@octokit/rest'; | |||
| import fetch, { RequestInit, Response } from 'node-fetch'; | |||
| import { fetch, Response, RequestInit } from 'undici'; | |||
There was a problem hiding this comment.
clearly its just not this simple.
There was a problem hiding this comment.
@punkle nope 😂 I would start from a fork of this repo and get things setup so that you can reproduce the error locally with the current setup, and then replace it in the GithubUrlReader and see what happens on your machine to test it.
There was a problem hiding this comment.
I don't think that we would want to just ship it for the GIthubUrlReader you see either.
There was a problem hiding this comment.
oh yeah. I probably should have made this a draft. Ive no intension of proposing this be merged without knowing it works. I suppose my patch demostrates though that ReadUrlResponseFactory#fromNodeJSReadable and ReadUrlResponseFactory#fromReadable cannot be used in the same way with undici.
There was a problem hiding this comment.
haha nice ok just wanted to make sure we're on the same level 😅 , and I think it's because we would need to use ]
import { stream } from 'undici' as the request method not fetch. The whatwg-fetch spec does not have any specification on response.body being a stream so theres a separate API for it as it tries to keep with the web spec.
|
Thank you @punkle, I've been able to reproduce this issue on existing implementation of |
|
@gavlyukovskiy this patch is not working at this point unfortunately. Ill try get back to it at some point. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hey, I just made a Pull Request!
use undici in place of node-fetch
The purpose of this patch is to attempt to fix an error that is appearing in the scaffolder fetch:plain:file action. It is throwing this error:
InternalServerError: stream is not readable✔️ Checklist
Signed-off-byline in the message. (more info)