Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set PropsWithChildren as explicit type on components #17672

Merged
merged 2 commits into from
May 25, 2023
Merged

set PropsWithChildren as explicit type on components #17672

merged 2 commits into from
May 25, 2023

Conversation

RobotSail
Copy link
Contributor

Signed-off-by: Oleg S 97077423+RobotSail@users.noreply.github.com

Hey, I just made a Pull Request!

This PR aims to prime the codebase for upgrading to React 18 by setting PropsWithChildren as an explicit type for components.

Part of #12252
Part of #17414

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@RobotSail RobotSail requested review from a team as code owners May 5, 2023 17:30
@RobotSail RobotSail requested review from freben and mikeyhc May 5, 2023 17:30
@github-actions github-actions bot added area:catalog Related to the Catalog Project Area homepage Features for the composable homepage area:scaffolder Everything and all things related to the scaffolder project area search Things related to Search labels May 5, 2023
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 5, 2023 •
edited
Loading

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • .changeset/weak-rats-serve.md: @backstage/core-plugin-api

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/core-app-api packages/core-app-api patch v1.8.0
@backstage/dev-utils packages/dev-utils patch v1.0.16-next.0
@backstage/plugin-scaffolder-react plugins/scaffolder-react patch v1.4.1-next.0
@backstage/plugin-scaffolder plugins/scaffolder patch v1.13.2-next.0

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023 •
edited
Loading

Uffizzi Preview deployment-24474 was deleted.

@RobotSail RobotSail requested a review from a team as a code owner May 5, 2023 18:19
@github-actions github-actions bot added the area:techdocs Related to the TechDocs Project Area label May 5, 2023
@RobotSail RobotSail force-pushed the update-props branch 2 times, most recently from 1005e67 to f25373e Compare May 5, 2023 18:39
@RobotSail
Copy link
Contributor Author

/retest

@github-actions github-actions bot added the microsite Changes to backstage.io label May 5, 2023
@RobotSail
Copy link
Contributor Author

This PR is definitely incomplete since it's hard to find all of the props needed to be wrapped in PropsWithChildren without upgrading to React 18. I will need to port over the changes from #17414 into this PR.

@awanlin awanlin mentioned this pull request May 9, 2023
Closed
@freben
Copy link
Member

freben commented May 10, 2023

Nice. Would you say it's still a work in progress then? Should it even be marked as a draft?

Remember to make a complete changeset then, too!

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 17, 2023
camilaibs
camilaibs approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the discovery plugins side, thank you!

@github-actions github-actions bot removed the stale label May 17, 2023
@awanlin
Copy link
Collaborator

awanlin commented May 23, 2023

Is there anything pending on this @RobotSail? Can it get reviewed? Sorry, we'd like to see this get in so doing some tracking

@RobotSail
Copy link
Contributor Author

Nothing pending on this @awanlin. I haven't been able to touch these PRs due to internal reprioritization, so it would be best to merge this and I can make any follow up PRs when needed.

@RobotSail @freben
set PropsWithChildren as explicit type on components
74b216e 
Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
@freben
Copy link
Member

freben commented May 24, 2023

Alright, rebased to fix the little conflict and will review

@freben
fixup the last bits
b2200ff 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
freben
freben approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I made a minor fixup to the types, and think this is ready to go!

@freben freben enabled auto-merge May 24, 2023 12:28
@freben freben disabled auto-merge May 25, 2023 09:03
@freben freben merged commit 255ff28 into backstage:master May 25, 2023
36 checks passed
@github-actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.15.0 release, scheduled for Tue, 20 Jun 2023.

@awanlin
Copy link
Collaborator

awanlin commented May 25, 2023

Excited to see this merged in many thanks @RobotSail! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben approved these changes

@camilaibs camilaibs camilaibs approved these changes

@mikeyhc mikeyhc Awaiting requested review from mikeyhc mikeyhc is a code owner automatically assigned from backstage/catalog-maintainers

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area homepage Features for the composable homepage microsite Changes to backstage.io search Things related to Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RobotSail @freben @awanlin @camilaibs