[search] Extend InputProps on <SearchBar/> #17697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
aitherios
changed the title
aitherios
commented
May 8, 2023
| }} | ||
| inputProps={{ | ||
| 'aria-label': ariaLabel, | ||
| ...defaultInputProps, | ||
| ...inputProps, |
There was a problem hiding this comment.
Changed the name from defaultInputProps to inputProps to avoid a clash with InputProps capital I.
There was a problem hiding this comment.
Since inputProps -> defaultInputProps would translate the same with InputProps.
|
Uffizzi Preview |
emmaindal
reviewed
May 8, 2023
In the current implementation of <SearchBar/> it is possible to overwrite the default <TextField/> InputProps by passing a prop of the same name. But sometimes is necessary to extend only, for example when one is interested on changing the clear button only. The clear button is supplied in the endAdornment, part of the InputProps, but at the same time the startAdornment is also on it. To be able to replace the clear button implementation without affecting the rest, this patch proposes a change where `InputProps` is exposed in the same manner as `inputProps` (notice the change from capital I to i). Where the received object may overwrite keys using the spread operator. Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
aitherios
force-pushed
the
expose-InputProps-on-SearchBar
branch
from
d27110c
to
19c0a8f
Compare
Thank you for helping out and the quick review =] |
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
In the current implementation of
<SearchBar/>it is possible to overwrite the default<TextField/>InputPropsby passing a prop of the same name. But sometimes is necessary to extend only, for example when one is interested on changing the clear button only.The clear button is supplied in the
endAdornment, part of theInputProps, but at the same time thestartAdornmentis also on it. To be able to replace the clear button implementation without affecting the rest, this patch proposes a change whereInputPropsis exposed in the same manner asinputProps(notice the change from capital I to i). Where the received object may overwrite keys using the spread operator.✔️ Checklist
Signed-off-byline in the message. (more info)