fix(plugin-search-react): improve SearchPagination page limit change handling #17700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Currently the
SearchPagination
component:does not reset the page cursor when page limit changes.
This can cause some weird situations, for example:
40-50
400-500
=> this is way past what results the user went throughThis PR fixes this behavior by resetting the page cursor when the page limit is changed.
Also, this PR fixes typescript typings by replacing the inexistent props omission
onPageLimitChange
prop with the correctonLimitChange
.✔️ Checklist
Signed-off-by
line in the message. (more info)