-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaffolder: extract ui:*
fields from conditional fields.
#17739
scaffolder: extract ui:*
fields from conditional fields.
#17739
Conversation
d08b799
to
3432626
Compare
Changed Packages
|
With this change the `ui:*` schema config is extracted also for the `then` and `else` branch of a conditional schema Signed-off-by: Andreas Berger <andreas@berger-ecommerce.com>
3432626
to
cf34311
Compare
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Do not close. Still waiting for review. |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Do not close. Still waiting for review. |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
@Rugvip Is there any plan to review this PR? |
@Andy2003 not until now 😅 somehow the GitHub automation failed to add it to our project board. Fixed that and will have a look in a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, makes sense, thank you! 🎉
Sorry about the delay, I'm gonna see if we can get some system in place to catch those hiccups
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
With this change the
ui:*
schema config is extracted also for thethen
andelse
branch of a conditional schema.Example schema:
✔️ Checklist
Signed-off-by
line in the message. (more info)