Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaffolder: extract ui:* fields from conditional fields. #17739

Merged
merged 1 commit into from
May 31, 2023

Conversation

Andy2003
Copy link
Contributor

With this change the ui:* schema config is extracted also for the then and else branch of a conditional schema.

Example schema:

parameters:
  - title: Fill in some steps
    properties:
      useUser:
        title: Use existing User
        type: boolean
    if:
      properties:
        useUser:
          const: true
    then:
      properties:
        user:
          type: string
          ui:field: EntityPicker
          ui:options:
            catalogFilter:
              - kind: User
    else:
      properties:
        name:
          type: string
        email:
          type: string

image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@Andy2003 Andy2003 requested a review from a team as a code owner May 10, 2023 13:30
@Andy2003 Andy2003 requested a review from Rugvip May 10, 2023 13:30
@Andy2003 Andy2003 force-pushed the bugfix/ui-schema-on-conditionals branch from d08b799 to 3432626 Compare May 10, 2023 13:42
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-react plugins/scaffolder-react patch v1.4.0-next.2

With this change the `ui:*` schema config is extracted also for the `then` and `else` branch of a conditional schema

Signed-off-by: Andreas Berger <andreas@berger-ecommerce.com>
@Andy2003 Andy2003 force-pushed the bugfix/ui-schema-on-conditionals branch from 3432626 to cf34311 Compare May 10, 2023 13:49
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label May 10, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 17, 2023
@Andy2003
Copy link
Contributor Author

Do not close. Still waiting for review.

@github-actions github-actions bot removed the stale label May 17, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 24, 2023
@Andy2003
Copy link
Contributor Author

Do not close. Still waiting for review.

@github-actions github-actions bot removed the stale label May 24, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 31, 2023
@Andy2003
Copy link
Contributor Author

@Rugvip Is there any plan to review this PR?

@github-actions github-actions bot removed the stale label May 31, 2023
@Rugvip
Copy link
Member

Rugvip commented May 31, 2023

@Andy2003 not until now 😅 somehow the GitHub automation failed to add it to our project board. Fixed that and will have a look in a bit

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense, thank you! 🎉

Sorry about the delay, I'm gonna see if we can get some system in place to catch those hiccups

@Rugvip Rugvip merged commit 1e9b8cb into backstage:master May 31, 2023
28 checks passed
@github-actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.15.0 release, scheduled for Tue, 20 Jun 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants