Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scaffolder): forward authorization header on event source #17754

Merged
merged 1 commit into from
May 17, 2023
Merged

fix(scaffolder): forward authorization header on event source #17754

merged 1 commit into from
May 17, 2023

Conversation

sanderaernouts
Copy link
Contributor

@sanderaernouts sanderaernouts commented May 11, 2023 •
edited
Loading

Hey, I just made a Pull Request!

Added the Authorization header to the event source for /api/scaffolder/v2/tasks/<id>/eventstream by replacing EventSource with EventSourcePolyfill. This resolves #16581

Verified that it works locally in our own backstage app:
image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label May 11, 2023
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder plugins/scaffolder patch v1.13.1-next.2

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

Uffizzi Preview deployment-24976 was deleted.

@sanderaernouts
fix(scaffolder): forward authorization header on event source
cda753a 
Signed-off-by: Sander Aernouts <sander.aernouts@gmail.com>
@sanderaernouts sanderaernouts requested a review from axiac May 14, 2023 07:17
@Rugvip Rugvip added the merge-after-release This is a bit too scary to merge until after the next release label May 15, 2023
@jhaals jhaals merged commit 0a2aa27 into backstage:master May 17, 2023
36 checks passed
@github-actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.15.0 release, scheduled for Tue, 20 Jun 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@jhaals jhaals Awaiting requested review from jhaals jhaals is a code owner automatically assigned from backstage/maintainers

@axiac axiac Awaiting requested review from axiac

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area merge-after-release This is a bit too scary to merge until after the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scaffolder: EventSource doesn't forward Authentication header
5 participants
@sanderaernouts @axiac @benjdlambert @jhaals @Rugvip