Enable override of sidebar selected indicator color when using createTheme #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rugvip
reviewed
Aug 9, 2020
packages/theme/src/types.ts
Outdated
| @@ -43,7 +43,10 @@ type PaletteAdditions = { | |||
| linkHover: string; | |||
| link: string; | |||
| gold: string; | |||
| sidebar: string; | |||
| sidebar: { | |||
There was a problem hiding this comment.
If you're up for extending this change a bit I think we should rename this, since sidebar is a bit of an implementation detail. Something like topNav or navigation would make sense I think, what do others think?
There was a problem hiding this comment.
Yep, fair enough. I think I'd go with navigation just so consistent with Material-UI (have pushed changes to that effect) but more than happy to take direction here if there is a preference.
stefanalund
approved these changes
Aug 11, 2020
|
Thank you @ContrarianChris and welcome to the Backstage community! 🎉 |
benjdlambert
added a commit
that referenced
this pull request
Aug 12, 2020
…g-in-gql * 'master' of github.com:spotify/backstage: (34 commits) fix(roadmap): switch links to milestones for v2 and v3 fix(roadmap): adjust project roadmap and link to use cases for v2 chore(deps-dev): bump @types/jest from 26.0.7 to 26.0.9 (#1905) Added v2 to techdocs readme Update README with new copy (#1900) Exclude microsite from the frontend CI workflow workflows: run broken link check in frontend CI docs: fix broken links docs: add basic script to verify local documentation links lint ignore microsite Add microsite to main repo Update design.md (#1898) Fix create-an-app.md output image (#1897) Enable override of sidebar selected indicator color when using createTheme (#1880) Remove extraneous tab test(scaffolder/docker): added some tests to check the home cariable chore(scaffolder): fixing some of the docs and making things a little cleanern chore(scaffolder): set a home directory for cookiecutter now we have new username and group id chores(scaffolder): trying something new chore(scaffolder): set the working directory default as the temp foler ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
I am working on an internal POC of Backstage and applying some simple brand colors with a custom theme but found the sidebar selected item color is not included in
PaletteAdditionsand is hardcoded in the sidebar layout, so cannot be set viacreateTheme.With this the default themes are unchanged but are now using refactored sidebar palette properties...
Using a custom theme now allows the selected indicator to be overridden as desired...
I hope my understanding is correct. I am brand new to React and am working to understand the Backstage codebase.
Thanks for the awesome project, this is my first every pull request!
✔️ Checklist
yarn test