Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated background and padding #19623

Merged
merged 1 commit into from Aug 31, 2023
Merged

Updated background and padding #19623

merged 1 commit into from Aug 31, 2023

Conversation

awanlin
Copy link
Collaborator

@awanlin awanlin commented Aug 26, 2023

Hey, I just made a Pull Request!

Updated the permissions digram to have a white background and roughly 10px padding all around

Closes #19558

Before After
Screenshot 2023-08-26 at 5 47 28 PM Screenshot 2023-08-26 at 5 47 17 PM

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin
Updated background and padding
fcc157b 
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
@awanlin awanlin requested review from a team as code owners August 26, 2023 22:50
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 26, 2023
@awanlin awanlin mentioned this pull request Aug 26, 2023
Closed
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2023 •
edited

Uffizzi Preview deployment-34492 was deleted.

camilaibs
camilaibs approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@camilaibs camilaibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the image 🙌🏻
Just left a question, nothing blocking this pull request 🙂

docs/assets/permissions/permission-framework-overview.drawio.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a white background via CSS to all images as an alternative when the dark theme is active?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @vinzscam suggested that in the related issue. I went this route as I felt that getting it fixed quickly was better then having it be really hard to read. Maybe we could log a more general Issue with a help wanted label to add this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I agree with you. Do you mind opening up the more general issue for us 🙏🏻 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, did a quick look and found this: #17712. Would that work or should I log something new for this?

freben
freben approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging in the mean time!

@freben freben merged commit a582c2a into backstage:master Aug 31, 2023
28 checks passed
@awanlin awanlin deleted the topic/add-white-bg-to-permission-diagram branch August 31, 2023 12:24
@awanlin
Copy link
Collaborator Author

awanlin commented Aug 31, 2023

Thanks @freben and @camilaibs 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilaibs camilaibs camilaibs approved these changes

@freben freben freben approved these changes

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: [Docs] Permission Diagram Hard to Read
3 participants
@awanlin @freben @camilaibs