Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins JobRunTable added #19881

Merged
merged 24 commits into from
Oct 14, 2023

Conversation

Abhay-soni-developer
Copy link
Contributor

I have added one more table in Jenkins plugin capable of showing all the builds triggers, for a particular job.

jobrun-table

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Sep 11, 2023

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-jenkins-backend plugins/jenkins-backend minor v0.2.9-next.2
@backstage/plugin-jenkins plugins/jenkins minor v0.8.7-next.2

@Abhay-soni-developer
Copy link
Contributor Author

please do the needful
@benjdlambert @NishkarshRaj @jhaals

Copy link
Contributor

@NishkarshRaj NishkarshRaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abhay: Interesting work!

Few changes needed before maintainers can take a look:

  • Changesets are missing
  • A simple TSC Check is failing: refer this

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Uffizzi Preview deployment-36037 was deleted.

.changeset/perfect-cobras-bake.md Outdated Show resolved Hide resolved
Copy link
Member

@adamdmharvey adamdmharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I would note I believe some of your date fields in the table could use the ADR around displaying dates maybe ? https://backstage.io/docs/architecture-decisions/adrs-adr012

Otherwise looks good. Minor suggestion re: an English typo.

Nice one !

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

Abhay-soni-developer commented Sep 12, 2023

@adamdmharvey @freben @camilaibs i think we are good to merge this now.

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Abhay-soni-developer, just left a comment about updates that should be made to the plugin's README

.changeset/perfect-cobras-bake.md Show resolved Hide resolved
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
.changeset/perfect-cobras-bake.md Outdated Show resolved Hide resolved
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert @NishkarshRaj @jhaals @awanlin i think we are ready to merge this branch, all the requested changes have been done too

@Abhay-soni-developer
Copy link
Contributor Author

any updates on this please drop your feedback if you want anything more to be done or please can we get this merge quickly
@benjdlambert @NishkarshRaj @jhaals @awanlin

@NishkarshRaj
Copy link
Contributor

https://github.com/backstage/backstage/actions/runs/6194714819/job/16818170902?pr=19881

One last bit needed: the API Report must be updated.

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert @NishkarshRaj @jhaals @awanlin
The API docs test which was failing, now runs successfully.
The merge is all set to be merged.

Thanks @NishkarshRaj for your consistent support.

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

Any updates over this pull request .

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

where are we with this pull request?
@freben @Rugvip

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, had a look at this!

plugins/jenkins-backend/src/service/router.ts Show resolved Hide resolved
plugins/jenkins/api-report.md Show resolved Hide resolved
plugins/jenkins/README.md Show resolved Hide resolved
plugins/jenkins/src/components/useJobRuns.ts Outdated Show resolved Hide resolved
plugins/jenkins/src/components/useJobRuns.ts Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Oct 2, 2023
@Abhay-soni-developer
Copy link
Contributor Author

OK, will now resume work on the feedbacks
and will contribute to this

@github-actions github-actions bot removed the stale label Oct 4, 2023
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert @Rugvip
made changes according to the feedbacks , please check this and get this merge if its all good from your side too.

@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert @jhaals @awanlin @tudi2d @Rugvip
please pay some attention to this PR, because I think we are very close to closing this PR

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright only optional comments, i feel maybe this can be ok now, let's see if others agree

plugins/jenkins/api-report.md Show resolved Hide resolved
plugins/jenkins/src/components/useJobRuns.ts Show resolved Hide resolved
plugins/jenkins/src/components/useJobRuns.ts Outdated Show resolved Hide resolved
plugins/jenkins/src/components/useJobRuns.ts Show resolved Hide resolved
@awanlin awanlin removed their request for review October 9, 2023 21:17
@freben
Copy link
Member

freben commented Oct 10, 2023

After merging the other PR, this has conflicts.

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert @jhaals @awanlin @tudi2d @Rugvip
I have worked on the last feedback too. are we good to move forward with this?

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

@Rugvip are ready to merge this now

@freben
Copy link
Member

freben commented Oct 12, 2023

you really just need to wait for the review like everyone else.

@freben freben merged commit 78bc50a into backstage:master Oct 14, 2023
27 checks passed
@github-actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.19.0 release, scheduled for Tue, 17 Oct 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants