-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins JobRunTable added #19881
jenkins JobRunTable added #19881
Conversation
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Changed Packages
|
please do the needful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abhay: Interesting work!
Few changes needed before maintainers can take a look:
- Changesets are missing
- A simple TSC Check is failing: refer this
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I would note I believe some of your date fields in the table could use the ADR around displaying dates maybe ? https://backstage.io/docs/architecture-decisions/adrs-adr012
Otherwise looks good. Minor suggestion re: an English typo.
Nice one !
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@adamdmharvey @freben @camilaibs i think we are good to merge this now. |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Abhay-soni-developer, just left a comment about updates that should be made to the plugin's README
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@benjdlambert @NishkarshRaj @jhaals @awanlin i think we are ready to merge this branch, all the requested changes have been done too |
any updates on this please drop your feedback if you want anything more to be done or please can we get this merge quickly |
https://github.com/backstage/backstage/actions/runs/6194714819/job/16818170902?pr=19881 One last bit needed: the API Report must be updated. |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@benjdlambert @NishkarshRaj @jhaals @awanlin Thanks @NishkarshRaj for your consistent support. |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Any updates over this pull request . |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, had a look at this!
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
OK, will now resume work on the feedbacks |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@benjdlambert @Rugvip |
@benjdlambert @jhaals @awanlin @tudi2d @Rugvip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright only optional comments, i feel maybe this can be ok now, let's see if others agree
After merging the other PR, this has conflicts. |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@benjdlambert @jhaals @awanlin @tudi2d @Rugvip |
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Rugvip are ready to merge this now |
you really just need to wait for the review like everyone else. |
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
I have added one more table in Jenkins plugin capable of showing all the builds triggers, for a particular job.