Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth backend module atlassian provider #21007

Merged

Conversation

handsamtw
Copy link
Contributor

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@handsamtw handsamtw requested review from a team as code owners November 6, 2023 20:11
@github-actions github-actions bot added the auth label Nov 6, 2023
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 6, 2023

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-auth-backend-module-atlassian-provider plugins/auth-backend-module-atlassian-provider minor v0.0.0
@backstage/plugin-auth-backend plugins/auth-backend patch v0.20.0-next.2

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Signed-off-by: Shousan Liao <samliao980822@gmail.com>
Signed-off-by: Shousan Liao <samliao980822@gmail.com>
Signed-off-by: Shousan Liao <samliao980822@gmail.com>
@handsamtw handsamtw force-pushed the auth-backend-module-atlassian-provider branch from 8636a4e to f7f20b7 Compare November 6, 2023 20:18
Signed-off-by: Shousan Liao <samliao980822@gmail.com>
@handsamtw
Copy link
Contributor Author

Hello @freben @tudi2d , this is my first open-source contribution, and I am very happy help out. However, I have some yarn install pipeline issue blocks me from passing the pipeline, is it possible to take a look?

I tried to commit my yarn.lock changes, but I can't due to the following error
Screenshot 2023-11-06 at 3 51 01 PM

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, good stuff!

.changeset/angry-gorillas-unite.md Outdated Show resolved Hide resolved
plugins/auth-backend/src/providers/atlassian/provider.ts Outdated Show resolved Hide resolved
@freben freben requested a review from Rugvip November 7, 2023 08:55
@handsamtw
Copy link
Contributor Author

Thank you @freben for the time! Really appreciate. I have resolved all problems you have pointed out

@freben
Copy link
Member

freben commented Nov 9, 2023

Hi! So close! You just missed a few bookkeeping things:

  • run yarn install and get the yarn.lock file added after that
  • run yarn build:api-reports to make sure that they are fresh, and add those too if changed
  • you missed a DCO signature, but that can be done easily after the fact, see the build output or the comment above for details

@freben
Copy link
Member

freben commented Nov 9, 2023

I'd help out doing those things, except the DCO check I cannot legally do

Signed-off-by: Shousan Liao <samliao980822@gmail.com>
Signed-off-by: Shousan Liao <samliao980822@gmail.com>
@handsamtw handsamtw force-pushed the auth-backend-module-atlassian-provider branch from 861189a to 2ff9373 Compare November 9, 2023 16:36
@handsamtw
Copy link
Contributor Author

I'd help out doing those things, except the DCO check I cannot legally do

Hi @freben , I really appreciate your help! I have signoff all previous commit.
I have tried the yarn install and commit the changes of yarn.lock file, but the error will come out as the screenshot I post at previous comment. It would be great if you can land me your help to wrap up my first open source contribution! Thank you very much.

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Uffizzi Cluster pr-21007 was deleted.

@freben freben merged commit d56f59f into backstage:master Nov 17, 2023
35 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.21.0 release, scheduled for Tue, 19 Dec 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants