Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new option from RJSF 5.15 #21783

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Use new option from RJSF 5.15 #21783

merged 1 commit into from
Dec 8, 2023

Conversation

solimant
Copy link
Contributor

@solimant solimant commented Dec 7, 2023 •
edited

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@solimant solimant requested review from a team as code owners December 7, 2023 16:26
@github-actions github-actions bot added homepage Features for the composable homepage area:scaffolder Everything and all things related to the scaffolder project area area:discoverability Related to the Discoverability Project Area labels Dec 7, 2023
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 7, 2023 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-home plugins/home patch v0.6.0-next.2
@backstage/plugin-scaffolder-react plugins/scaffolder-react patch v1.6.2-next.2
@backstage/plugin-scaffolder plugins/scaffolder patch v1.16.2-next.2

@solimant solimant mentioned this pull request Dec 7, 2023
Closed
2 tasks
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023 •
edited

Uffizzi Cluster pr-21783 was deleted.

@solimant
Use new option from RJSF 5.15
c8908d4 
Signed-off-by: solimant <solimant@users.noreply.github.com>
benjdlambert
benjdlambert approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks 👍

@benjdlambert
Copy link
Member

I think that these test failures are unrelated and are part of frenic/csstype#189

@benjdlambert benjdlambert merged commit 7211803 into backstage:master Dec 8, 2023
26 of 28 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.21.0 release, scheduled for Tue, 19 Dec 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@Rugvip Rugvip Awaiting requested review from Rugvip Rugvip is a code owner automatically assigned from backstage/maintainers

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:discoverability Related to the Discoverability Project Area area:scaffolder Everything and all things related to the scaffolder project area homepage Features for the composable homepage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@solimant @benjdlambert