Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaffolder-backend-module-gitlab: add gitlab:issues:create custom action #21929

Merged
merged 19 commits into from Jan 10, 2024
Merged

scaffolder-backend-module-gitlab: add gitlab:issues:create custom action #21929

merged 19 commits into from Jan 10, 2024

Conversation

elaine-mattos
Copy link
Contributor

Hey, I just made a Pull Request!

This creates a new GitLab Scaffolder custom action that allows Gitlab users to create issues. This is a quick summary of what was done:

  • Added the action, its examples and tests;
  • Added more helper functions and its tests;
  • Added template example to the readme.md file;
  • Used the @gitbeaker/rest library as the @gitbeaker/node has been deprecated;

✔️ Checklist

  • A changeset describing the change and affected packages. ([more info]
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. ([more info]

@elaine-mattos
feat: add gitlab create issues custom action
d5ede22 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
fix: fixed some issues
96b8bf4 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
wip: add features
8d5867e 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
feat: added initial tests
b24b0a2 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
wip: add some more tests
ab53440 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
feat: add new tests
31904c7 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
feat: add epic scope tests
40dcabc 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
feat: remove unused code
99b1098 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
feat: restore space
0404e98 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Dec 19, 2023
@elaine-mattos elaine-mattos marked this pull request as draft December 19, 2023 06:38
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 19, 2023 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-scaffolder-backend-module-gitlab plugins/scaffolder-backend-module-gitlab patch v0.2.12-next.2

@elaine-mattos
fix: add barrel file and fix typos
604c9dd 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
Merge branch 'master' into feature/gitlab-issues
53e646e 
Signed-off-by: Elaine Mattos <79633988+elaine-mattos@users.noreply.github.com>
@elaine-mattos elaine-mattos marked this pull request as ready for review December 19, 2023 13:05
@elaine-mattos
chore: run prettier
3aa043a 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
chore: add api-report.md
ae92a9d 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
fix: add public decorator
e61ed09 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos elaine-mattos mentioned this pull request Dec 19, 2023
Closed
2 tasks
benjdlambert
benjdlambert reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good at first glance, just a question about the enums and if we can do those a slightly different way so that they're in the jsonschema? 🙏

plugins/scaffolder-backend-module-gitlab/src/actions/createGitlabIssueAction.ts Outdated
.optional(),
labels: z.string({ description: 'Labels to apply' }).optional(),
issueType: z
.string({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's possible to use nativeEnums here instead?

https://github.com/colinhacks/zod#native-enums

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys,

it's done. Please let me know what you think! :)

@elaine-mattos
feat: change simple enum to zod native enums
2a3360a 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
fix: change test input type
728e1a0 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
fix: export enum type
578a529 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
fix: add api-report
fd3d01c 
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 2, 2024
@github-actions github-actions bot closed this Jan 7, 2024
@elaine-mattos
Copy link
Contributor Author

Hi @benjdlambert ,

I just received the notification of this PR being closed due to lack of activity. Is there anything here that still needs to be done on my part?
Please let me know! :)

@freben
Copy link
Member

freben commented Jan 8, 2024

We've been away for vacations - reopening!

@freben freben reopened this Jan 8, 2024
@github-actions github-actions bot removed the stale label Jan 8, 2024
@benjdlambert
Update flat-terms-provide.md
5e554f1 
Signed-off-by: Ben Lambert <ben@blam.sh>
benjdlambert
benjdlambert approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@benjdlambert benjdlambert merged commit add0352 into backstage:master Jan 10, 2024
28 of 32 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.22.0 release, scheduled for Tue, 16 Jan 2024.

@tudi2d tudi2d mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elaine-mattos @freben @benjdlambert