-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change script in **UrlReaderProcessor.ts** adding some code to handle URL Reader from GCS with wildcard /* #22141
Conversation
Changed Packages
|
Hi All! Just for your knowledge, my PR is failling in just two test that are nothing to do with the change l made. failing test: E2E Linux / E2E Linux 18.x (pull_request) |
Yep, those will stay broken until mui/material-ui#40427 is fixed |
ec8028e
to
0ea52bd
Compare
Hey guys 👋, I just want to follow up this open issue PR, l have replaced the line const { filepath } = parseGitUrl(location); with const { pathname: filepath } = new URL(location); looks like it has worked. Let me know your comments. Thank you for taking the time to review them |
@armandocomellas1 did you mean to keep all the other changes to the other files that you've made like the I think that you might want to revert the other changes as they don't seem relevant for this bug fix, maybe you can explain what these other changes do in another PR and what issue they are trying to solve as I don't see the overlap here. Thanks! |
Yeah, that's my bad, l mixed both issue solution in this PR, l had in my local repo the solution for the Gke backend auth, but they are two completley separetly things, if you want l can close this issue, and l will open a new PR for each issue. Thanks! |
Signed-off-by: armandocomellas1 <cgarmando@google.com>
e194b4b
to
c3249d6
Compare
…eset thirty-cats-help.md Signed-off-by: armandocomellas1 <cgarmando@google.com>
…eset thirty-cats-help.md Signed-off-by: armandocomellas1 <cgarmando@google.com>
Hi Guys! @benjdlambert @jamieklassen Please if you can review l will be happy to hear any news. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment on the changeset. Do you think you could also add a test for this too?
Handing over to @backstage/catalog-maintainers after the suggestions are done. |
…st for new URL method Signed-off-by: armandocomellas1 <cgarmando@google.com>
…guments Signed-off-by: blam <ben@blam.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce! Thanks for this! I just updated the test a little bit because I would like to get this in the release today 🎉
Uffizzi Cluster |
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
This fixes bug #21955
✔️ Checklist
Signed-off-by
line in the message. (more info)The implementation consist in adding a path with wildcard starting with https://storage.cloud.google.com/[bucketname]/*
and the wilcard is to load all the files inside the bucket and not just a single one with the full path
So the behavior is:
Before implementation we had this:
After implementarion:
So as you can see after the implementation the UI is capable to render all the components loaded from a relative path with wildcard.
Thank you for reviewing the pull request.