Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization and Clarity Enhancement for Intro to Plugins Documentation #23266

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

markjacksonfishing
Copy link
Contributor

@markjacksonfishing markjacksonfishing commented Feb 26, 2024

Hey, I just made a Pull Request!

Optimization and Clarity Enhancement for Intro to Plugins Documentation

This pull request introduces a series of enhancements aimed at optimizing the structure of the "Introduction to Plugins" documentation. The initial commit refines the document for clarity, readability, and markdown best practices, setting a solid foundation for further updates. Subsequent commits will address specific requirements and suggestions arising from issue #21945 on the Backstage GitHub repository.

Key Highlights:

  • Initial Commit: Streamlines language, updates link descriptions for better clarity, and revises the document's layout for improved navigability and user experience. This includes refining alt text for images to enhance accessibility.
  • Following Commits: Will incorporate feedback and suggestions as detailed in issue 🚀 Feature: Write an integrator guide #21945, focusing on expanding the documentation to cover new plugin development guidelines, integration tips, and examples.
  • New Table of Contents: Introducing a "Coming Soon: Table of Contents" for "Backstage Integration Essentials: A Complete Guide to Plugin Development," offering a sneak peek into future documentation structure and topics, including foundational development concepts, advanced integration techniques, deployment best practices, troubleshooting, and real-world case studies.

Objective:

My goal is to ensure that the "Introduction to Plugins" section serves as a comprehensive, easily navigable, and user-friendly resource for both new and existing Backstage contributors. By aligning this documentation more closely with community feedback and the evolving landscape of plugin development, I aim to foster a more vibrant and collaborative ecosystem.

Invitation for Collaboration:

Feedback, suggestions, and contributions are welcomed to continuously improve this documentation. If you have insights or enhancements to propose, please feel free to comment on this PR or contribute directly to the discussion in issue #21945.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: markyjackson-taulia <marky.r.jackson@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 26, 2024
Signed-off-by: markyjackson-taulia <marky.r.jackson@gmail.com>
Copy link
Contributor

@aramissennyeydd aramissennyeydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up 🎉, excited to see this guide start moving!

docs/plugins/index.md Outdated Show resolved Hide resolved
docs/plugins/index.md Outdated Show resolved Hide resolved
docs/plugins/index.md Outdated Show resolved Hide resolved
docs/plugins/index.md Outdated Show resolved Hide resolved
docs/plugins/index.md Outdated Show resolved Hide resolved
docs/plugins/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 9, 2024
@sennyeya sennyeya removed the stale label Mar 9, 2024
@markjacksonfishing
Copy link
Contributor Author

@aramissennyeydd, I will incorporate these and my new work this week. Thank you for all the feedback!

@aramissennyeydd
Copy link
Contributor

@markjacksonfishing Looking forward to it!

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 18, 2024
@markjacksonfishing
Copy link
Contributor Author

@aramissennyeydd can you remove the stale label? I have work to submit but still working through it.

@github-actions github-actions bot removed the stale label Mar 19, 2024
@aramissennyeydd
Copy link
Contributor

@markjacksonfishing If you comment, it will remove the label if you don't have access to directly remove it, "shoo stalebot 🌬️ " is a favorite of mine.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 26, 2024
@markjacksonfishing
Copy link
Contributor Author

Still working on this after travels.

@github-actions github-actions bot removed the stale label Mar 27, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 3, 2024
@markjacksonfishing
Copy link
Contributor Author

I will have the updated committed by eod today.

@github-actions github-actions bot removed the stale label Apr 3, 2024
Signed-off-by: markyjacksonfishing <marky.r.jackson@gmail.com>
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 10, 2024
@markjacksonfishing
Copy link
Contributor Author

I am still working through this—a lot of material to pull in and adjust, but it is still in progress and active.

@github-actions github-actions bot removed the stale label Apr 10, 2024
@markjacksonfishing
Copy link
Contributor Author

Today I will have the edits addressed.

Signed-off-by: markyjacksonfishing <marky.r.jackson@gmail.com>
Signed-off-by: markyjackson-taulia <marky.r.jackson@gmail.com>
Copy link
Contributor

github-actions bot commented Apr 21, 2024

Uffizzi Ephemeral Environment - Virtual Cluster

☁️ deploying cluster pr-23266

⚙️ Updating now by workflow run 8774697010.

Download the Uffizzi CLI to interact with the upcoming virtual cluster
https://docs.uffizzi.com/install

@markjacksonfishing
Copy link
Contributor Author

I will continue debugging the GHA failure tomorrow.

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm gonna rudely mark this as ready for review so that we get some maintainers assigned

.github/workflows/verify_microsite.yml Outdated Show resolved Hide resolved
@Rugvip Rugvip marked this pull request as ready for review April 22, 2024 11:47
@Rugvip Rugvip requested review from a team as code owners April 22, 2024 11:47
@markjacksonfishing
Copy link
Contributor Author

Thank you! I'm gonna rudely mark this as ready for review so that we get some maintainers assigned

@Rugvip i will tinker with the GHA later this morning.

@Rugvip
Copy link
Member

Rugvip commented Apr 22, 2024

@markjacksonfishing what's the GHA problem you're aiming to fix?

@markjacksonfishing
Copy link
Contributor Author

@markjacksonfishing, what's the GHA problem you're aiming to fix?

@Rugvip, mainly this one, but I will be very transparent about the fact that the error could totally be me missing something.

@aramissennyeydd
Copy link
Contributor

@markjacksonfishing @Rugvip I think something's up with the microsite build step, getting this error in #24069 as well

@markjacksonfishing
Copy link
Contributor Author

@markjacksonfishing @Rugvip I think something's up with the microsite build step, getting this error in #24069 as well

@aramissennyeydd Yep, same thing. I attempted to untwine the ball o string here, but that opened a pandora error box, and I reverted it.

Signed-off-by: markyjackson-taulia <marky.r.jackson@gmail.com>
@markjacksonfishing
Copy link
Contributor Author

@aramissennyeydd, do the items I added to the outline look suitable? If so, I have more to add, but I want to ensure we are aligned.

@aramissennyeydd
Copy link
Contributor

@markjacksonfishing LGTM, @awanlin and @vinzscam / @benjdlambert, can you also take a quick look?

@awanlin
Copy link
Collaborator

awanlin commented Apr 30, 2024

Sure, will give it a look. Also seems a conflict crept in.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@markjacksonfishing
Copy link
Contributor Author

@aramissennyeydd if the table of contents is good, I will get moving (already have items).

@aramissennyeydd
Copy link
Contributor

@markjacksonfishing Go for it! 🚀

Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work your doing on this @markjacksonfishing, finally got some time to look this over.


![plugin](../assets/plugins/my-plugin_screenshot.png)
![Plugin Screenshot](../assets/plugins/my-plugin_screenshot.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really take the time to update this image as it doesn't match the current state

be presented as a part of a Software Catalog (e.g. a separate tab or a card on
an "Overview" tab), then check out
[the instruction](integrating-plugin-into-software-catalog.md) on how to do it.
Should your plugin complement the Software Catalog rather than exist as a standalone entity (for instance, as an additional tab or a card within an "Overview" tab), you'll find comprehensive guidance on achieving this integration [here](integrating-plugin-into-software-catalog.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a different word then "entity" here, it's a bit overloaded. I think you mean like the way TechRadar or Cost Insights are only access via the sidebar when you say entity here but for those new to Backstage that might not be obvious. We also uses entity to mean items in the Catalog so it's a bit confusing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's try and adjust using "here" for the link


To create a plugin, follow the steps outlined [here](create-a-plugin.md).
Embark on your plugin development journey by following the detailed steps provided [here](create-a-plugin.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help avoid using "here" as the link I like to say:

Suggested change
Embark on your plugin development journey by following the detailed steps provided [here](create-a-plugin.md).
Embark on your plugin development journey by following the detailed steps provided in the [Create a Plugin](create-a-plugin.md) documentation.

This is for those ready to explore complex challenges and enhance their plugins with advanced features.

- **Plugins 301: Advanced Topics in Plugin Development**
- Enabling resource-level authorization and interfacing with external services, SCMs, or databases.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about this coming so late, general experience is that most initial plugins are based around: "I want to integrate with System X usually via its API".

- Detailed guidance on starting and iterating on a plugin development project.
- Engaging with the community and stakeholders to propel your project.

### For Intermediate Users: Scaling Your Plugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Is "scaling" the right word here? What comes to my mind first is more technical - horizontal and vertical - that might also be what others think. I'm not sure what the better wording would be right now though 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like "Bringing Your Plugin to Production"


This section is designed for those new to plugin development. It covers the basics and provides a foundation for more advanced topics.

- **Plugins 101: Building Your First Plugin**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need these headings for the lists? There's already a main heading that seems pretty clear. The 101, 201, and 301 terminology may not be universal.

- In-depth exploration of fostering an inner source mentality and understanding adoption dynamics.
- Decision-making frameworks: choosing between developing a new plugin or utilizing an existing open-source solution.

## Additional Resources and Further Reading
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to add links here? Right now this doesn't look to be terribly helpful 🤔

@markjacksonfishing
Copy link
Contributor Author

Just wanted to give an update that I am still working through the edits and new content. More to come this week.

@markjacksonfishing
Copy link
Contributor Author

I just wanted to give an update that I will have a good chunk done in the next week.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jun 7, 2024
@markjacksonfishing
Copy link
Contributor Author

This is still ongoing. I have items ready, but I'm doing some final checks

@github-actions github-actions bot removed the stale label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants