Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add catalog i18n #23392

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feat/add catalog i18n #23392

wants to merge 9 commits into from

Conversation

mario-mui
Copy link
Contributor

@mario-mui mario-mui commented Mar 5, 2024 •
edited

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@mario-mui mario-mui requested review from a team as code owners March 5, 2024 09:25
@github-actions github-actions bot added area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area labels Mar 5, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Mar 5, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react patch v1.12.1-next.2
@backstage/plugin-catalog plugins/catalog patch v1.21.0-next.3

@mario-mui
Copy link
Contributor Author

Another version for #20841

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-23392 was successfully created. Learn more about Uffizzi virtual clusters
To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login

Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-23392 --kubeconfig=[PATH_TO_KUBECONFIG]
    After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-23392-c4064.uclusters.app.uffizzi.com

@mario-mui mario-mui mentioned this pull request Mar 5, 2024
Open
2 tasks
@mario-mui
Copy link
Contributor Author

@benjdlambert please review this PR 😁

@benjdlambert benjdlambert added the merge-after-release This is a bit too scary to merge until after the next release label Mar 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 20, 2024
@mario-mui
Copy link
Contributor Author

ping

@github-actions github-actions bot removed the stale label Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Mar 28, 2024
@freben freben removed the stale label Mar 28, 2024
@freben
Copy link
Member

freben commented Mar 28, 2024

Hey, sorry but a rebase is needed

@mario-mui
Copy link
Contributor Author

Hey, sorry but a rebase is needed

done

@benjdlambert
Copy link
Member

@mario-mui the build is red at the minute, looks like somethings need fixing up 🙏

@mario-mui
Copy link
Contributor Author

@mario-mui the build is red at the minute, looks like somethings need fixing up 🙏

Yeap

@mario-mui
Copy link
Contributor Author

@benjdlambert I had fixed all actions expect Accessibility, it seems not my fault

@freben freben mentioned this pull request Apr 11, 2024
Closed
2 tasks
@mario-mui
Copy link
Contributor Author

ping @benjdlambert

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 6, 2024
@benjdlambert benjdlambert removed the stale label May 6, 2024
@mario-mui
Copy link
Contributor Author

@benjdlambert Shall we start review this PR, 😄

@benjdlambert
Copy link
Member

@mario-mui sorry - been a busy few weeks so not had chance to get round to this yet!

@mario-mui
Copy link
Contributor Author

@mario-mui sorry - been a busy few weeks so not had chance to get round to this yet!

sure, can someone else review this pr ？

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jun 17, 2024
@mattemoore
Copy link

Any way a non-contributor can help on this PR? Really need this to satisfy official languages support for adoption in Canadian government.

@github-actions github-actions bot removed the stale label Jun 17, 2024
@freben
Copy link
Member

freben commented Jun 17, 2024

I see there are conflicts now.

We'll get to it as soon as possible.

@mario-mui
Copy link
Contributor Author

mario-mui commented Jun 18, 2024 •
edited

I see there are conflicts now.

We'll get to it as soon as possible.

ok，It's done @freben

@mario-mui
feat: add i18n to plugin-catalog
c324de8 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
feat: add i18n to plugin-catalog-react
06c0956 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
chore: update changelog
b549476 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
fix: unit test
951e2da 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
fix: ci pipeline prettier:check error
0b03dd0 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
fix: update api report
430c8fb 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
fix: unit test
24208fc 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
fix: rebase conficts
847d174 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
@mario-mui
fix: EntityNamespacePicker test
582dfb5 
Signed-off-by: mario ma <mario.ma.node@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeyhc mikeyhc mikeyhc left review comments

@benjdlambert benjdlambert Awaiting requested review from benjdlambert benjdlambert is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area area:scaffolder Everything and all things related to the scaffolder project area merge-after-release This is a bit too scary to merge until after the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mario-mui @freben @benjdlambert @mattemoore @mikeyhc