Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth-backend-module-azure-easyauth-provider #23909

Merged
merged 6 commits into from Apr 16, 2024
Merged

Add auth-backend-module-azure-easyauth-provider #23909

merged 6 commits into from Apr 16, 2024

Conversation

yaegashi
Copy link
Contributor

@yaegashi yaegashi commented Mar 31, 2024 •
edited

Hey, I just made a Pull Request!

Add the azure-easyauth provider plugin for the new auth backend system.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the auth label Mar 31, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Mar 31, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-auth-backend-module-azure-easyauth-provider plugins/auth-backend-module-azure-easyauth-provider minor v0.0.0
@backstage/plugin-auth-backend plugins/auth-backend patch v0.22.4-next.1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2024 •
edited

Uffizzi Cluster pr-23909 was deleted.

@yaegashi yaegashi force-pushed the new-azure-easyauth branch 3 times, most recently from c6599ea to ccf2b9e Compare March 31, 2024 11:26
@yaegashi yaegashi mentioned this pull request Mar 31, 2024
Open
19 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 7, 2024
@Rugvip Rugvip removed the stale label Apr 7, 2024
@Rugvip Rugvip marked this pull request as ready for review April 7, 2024 13:03
@Rugvip Rugvip requested review from backstage-service and a team as code owners April 7, 2024 13:03
@Rugvip Rugvip requested review from freben and camilaibs April 7, 2024 13:03
@yaegashi yaegashi force-pushed the new-azure-easyauth branch 2 times, most recently from 98e4e54 to c256af7 Compare April 11, 2024 12:55
@yaegashi
Copy link
Contributor Author

yaegashi commented Apr 11, 2024 •
edited

@Rugvip @freben @camilaibs Thanks for reviewing this PR.

I have refactored the legacy azure-easyauth provider and I believe it's ready to merge.

awanlin
awanlin requested changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @yaegashi, haven't done a full review but just wanted to mention can you please make sure to update the related auth docs as well, these ones: https://github.com/backstage/backstage/blob/master/docs/auth/microsoft/azure-easyauth.md. All you should need to do is update the config example at the beginning with the proper signIn.resolvers

@awanlin awanlin mentioned this pull request Apr 12, 2024
Open
46 tasks
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 14, 2024
@yaegashi yaegashi force-pushed the new-azure-easyauth branch 2 times, most recently from 5738f4d to 4858da7 Compare April 14, 2024 06:47
@yaegashi yaegashi requested a review from awanlin April 14, 2024 07:25
@yaegashi
Copy link
Contributor Author

@awanlin Thanks, updated auth docs as requested.

@yaegashi @freben
Add auth-backend-module-azure-easyauth-provider
06a6725 
Signed-off-by: YAEGASHI Takeshi <yaegashi@gmail.com>
@yaegashi @freben
Refactor auth-backend azure-easyauth provider
f02fe79 
Signed-off-by: YAEGASHI Takeshi <yaegashi@gmail.com>
@yaegashi @freben
Update the azure-easyauth provider docs for the new backend system
5796275 
Signed-off-by: YAEGASHI Takeshi <yaegashi@gmail.com>
@freben
Copy link
Member

freben commented Apr 16, 2024

Took the liberty of rebasing this one after another pull request made it required to do so

Rugvip
Rugvip approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 👍

Let's :shipit:

plugins/auth-backend-module-azure-easyauth-provider/src/module.ts Show resolved Hide resolved
@Rugvip
changesets: mention breaking easyAuth provider ID in changeset
e9f1b45 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
auth-backend-module-azure-easyauth-provider: review fixes
f999ad1 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip
changesets: be more explicit about easyAuth ID breakage
a9d1b56 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip merged commit c786f06 into backstage:master Apr 16, 2024
38 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.26.0 release, scheduled for Tue, 14 May 2024.

@freben freben mentioned this pull request Apr 16, 2024
Merged
@awanlin
Copy link
Collaborator

awanlin commented Apr 16, 2024

Thanks for including the doc updates @yaegashi 🚀

@yaegashi yaegashi deleted the new-azure-easyauth branch April 17, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben left review comments

@Rugvip Rugvip Rugvip approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

@awanlin awanlin Awaiting requested review from awanlin

Assignees
No one assigned
Labels
auth documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yaegashi @freben @awanlin @Rugvip