Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change most of plugins to use LoggerService #24224

Merged
merged 6 commits into from Apr 15, 2024
Merged

chore: change most of plugins to use LoggerService #24224

merged 6 commits into from Apr 15, 2024

Conversation

drodil
Copy link
Contributor

@drodil drodil commented Apr 12, 2024

Hey, I just made a Pull Request!

quite a big PR for this but the changes are pretty stright forward. hopefully gets merged before most of these plugins move to the community repository.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added area:catalog Related to the Catalog Project Area area:techdocs Related to the TechDocs Project Area area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. search Things related to Search area:scaffolder Everything and all things related to the scaffolder project area area:permission Related to the Permission Project Area area:discoverability Related to the Discoverability Project Area labels Apr 12, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 12, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-app-api packages/backend-app-api patch v0.7.0-next.1
@backstage/backend-tasks packages/backend-tasks patch v0.5.22-next.1
@backstage/plugin-adr-backend plugins/adr-backend patch v0.4.14-next.1
@backstage/plugin-airbrake-backend plugins/airbrake-backend patch v0.3.14-next.1
@backstage/plugin-app-backend plugins/app-backend patch v0.3.65-next.1
@backstage/plugin-azure-devops-backend plugins/azure-devops-backend patch v0.6.4-next.1
@backstage/plugin-azure-sites-backend plugins/azure-sites-backend patch v0.3.4-next.1
@backstage/plugin-badges-backend plugins/badges-backend patch v0.3.14-next.1
@backstage/plugin-bazaar-backend plugins/bazaar-backend patch v0.3.15-next.1
@backstage/plugin-catalog-backend-module-aws plugins/catalog-backend-module-aws patch v0.3.12-next.1
@backstage/plugin-catalog-backend-module-azure plugins/catalog-backend-module-azure patch v0.1.37-next.1
@backstage/plugin-catalog-backend-module-bitbucket-server plugins/catalog-backend-module-bitbucket-server patch v0.1.31-next.1
@backstage/plugin-catalog-backend-module-gcp plugins/catalog-backend-module-gcp patch v0.1.18-next.1
@backstage/plugin-catalog-backend-module-gerrit plugins/catalog-backend-module-gerrit patch v0.1.34-next.1
@backstage/plugin-catalog-backend-module-github-org plugins/catalog-backend-module-github-org patch v0.1.12-next.1
@backstage/plugin-catalog-backend-module-github plugins/catalog-backend-module-github patch v0.5.8-next.1
@backstage/plugin-catalog-backend-module-gitlab plugins/catalog-backend-module-gitlab patch v0.3.15-next.1
@backstage/plugin-catalog-backend-module-incremental-ingestion plugins/catalog-backend-module-incremental-ingestion patch v0.4.22-next.1
@backstage/plugin-catalog-backend-module-msgraph plugins/catalog-backend-module-msgraph patch v0.5.25-next.1
@backstage/plugin-catalog-backend-module-puppetdb plugins/catalog-backend-module-puppetdb patch v0.1.23-next.1
@backstage/plugin-catalog-backend plugins/catalog-backend patch v1.21.1-next.1
@backstage/plugin-code-coverage-backend plugins/code-coverage-backend patch v0.2.31-next.1
@backstage/plugin-devtools-backend plugins/devtools-backend patch v0.3.3-next.1
@backstage/plugin-entity-feedback-backend plugins/entity-feedback-backend patch v0.2.14-next.1
@internal/plugin-todo-list-backend plugins/example-todo-list-backend none v1.0.26-next.1
@backstage/plugin-explore-backend plugins/explore-backend patch v0.0.27-next.1
@backstage/plugin-jenkins-backend plugins/jenkins-backend patch v0.4.4-next.1
@backstage/plugin-kafka-backend plugins/kafka-backend patch v0.3.15-next.1
@backstage/plugin-kubernetes-backend plugins/kubernetes-backend minor v0.17.0-next.1
@backstage/plugin-lighthouse-backend plugins/lighthouse-backend patch v0.4.10-next.1
@backstage/plugin-linguist-backend plugins/linguist-backend patch v0.5.15-next.1
@backstage/plugin-nomad-backend plugins/nomad-backend patch v0.1.19-next.1
@backstage/plugin-periskop-backend plugins/periskop-backend patch v0.2.15-next.1
@backstage/plugin-permission-backend plugins/permission-backend patch v0.5.41-next.1
@backstage/plugin-playlist-backend plugins/playlist-backend patch v0.3.21-next.1
@backstage/plugin-scaffolder-backend-module-github plugins/scaffolder-backend-module-github patch v0.2.7-next.1
@backstage/plugin-search-backend-module-explore plugins/search-backend-module-explore patch v0.1.21-next.1
@backstage/plugin-search-backend-module-stack-overflow-collator plugins/search-backend-module-stack-overflow-collator patch v0.1.10-next.1
@backstage/plugin-search-backend-module-techdocs plugins/search-backend-module-techdocs patch v0.1.22-next.1
@backstage/plugin-search-backend-node plugins/search-backend-node patch v1.2.21-next.1
@backstage/plugin-search-backend plugins/search-backend patch v1.5.7-next.1
@backstage/plugin-sonarqube-backend plugins/sonarqube-backend patch v0.2.19-next.1
@backstage/plugin-tech-insights-backend-module-jsonfc plugins/tech-insights-backend-module-jsonfc patch v0.1.49-next.1
@backstage/plugin-tech-insights-backend plugins/tech-insights-backend patch v0.5.31-next.1
@backstage/plugin-tech-insights-node plugins/tech-insights-node minor v0.5.3-next.1
@backstage/plugin-todo-backend plugins/todo-backend patch v0.3.16-next.1

@drodil drodil force-pushed the logger_service branch 3 times, most recently from 253ae79 to e847468 Compare April 12, 2024 22:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024 •
edited

Uffizzi Cluster pr-24224 was deleted.

@drodil drodil force-pushed the logger_service branch 2 times, most recently from b793659 to b94a976 Compare April 12, 2024 23:08
@drodil
chore: change most of plugins to use LoggerService
d5a1fe1 
quite a big PR for this but the changes are pretty stright forward.
hopefully gets merged before most of these plugins move to the community
repository.

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
@Rugvip
Merge branch 'master' into logger_service
e297ea7 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Rugvip
Rugvip requested changes Apr 14, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy shit this is awesome, thank you! 😁 ❤️

Agree it's best to ship this asap. There are some breaking changes that I suggest we skip for now.

plugins/kubernetes-backend/src/service/KubernetesProxy.ts Outdated Show resolved Hide resolved
plugins/techdocs-node/src/stages/publish/azureBlobStorage.ts Outdated Show resolved Hide resolved
plugins/tech-insights-node/api-report.md Show resolved Hide resolved
plugins/kubernetes-backend/api-report.md Show resolved Hide resolved
plugins/scaffolder-node/api-report.md Outdated Show resolved Hide resolved
plugins/techdocs-node/api-report.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the area:techdocs Related to the TechDocs Project Area label Apr 15, 2024
drodil and others added 2 commits April 15, 2024 08:15
@drodil @Rugvip
Update plugins/kubernetes-backend/src/service/KubernetesProxy.ts
eabeac8 
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
@drodil
fix: review findings
5dd8177 
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
@drodil
fix: lockfile maintenance
497879c 
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
@drodil drodil requested a review from Rugvip April 15, 2024 06:01
Rugvip
Rugvip approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's :shipit: 🎉

.changeset/gentle-crabs-cover.md Outdated Show resolved Hide resolved
@Rugvip
Update .changeset/gentle-crabs-cover.md
ba757e4 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip merged commit b464404 into backstage:master Apr 15, 2024
36 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.26.0 release, scheduled for Tue, 14 May 2024.

@freben freben mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

@Xantier Xantier Awaiting requested review from Xantier Xantier is a code owner

@kuangp kuangp Awaiting requested review from kuangp kuangp is a code owner

@awanlin awanlin Awaiting requested review from awanlin awanlin is a code owner

@andrewthauer andrewthauer Awaiting requested review from andrewthauer andrewthauer is a code owner

@alde alde Awaiting requested review from alde alde is a code owner

@pjungermann pjungermann Awaiting requested review from pjungermann pjungermann is a code owner

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

@acierto acierto Awaiting requested review from acierto acierto is a code owner automatically assigned from backstage/scaffolder-maintainers

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area area:discoverability Related to the Discoverability Project Area area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. area:permission Related to the Permission Project Area area:scaffolder Everything and all things related to the scaffolder project area search Things related to Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drodil @Rugvip