Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): migrate Bitbucket auth provider to module package #24287

Merged
merged 1 commit into from Apr 16, 2024
Merged

feat(auth): migrate Bitbucket auth provider to module package #24287

merged 1 commit into from Apr 16, 2024

Conversation

pjungermann
Copy link
Contributor

Migrate the Bitbucket auth provider to the new @backstage/plugin-auth-backend-module-bitbucket-provider module package.

Relates-to: #19476

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the auth label Apr 16, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 16, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-auth-backend-module-bitbucket-provider plugins/auth-backend-module-bitbucket-provider minor v0.0.0
@backstage/plugin-auth-backend plugins/auth-backend patch v0.22.4-next.1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited

Uffizzi Cluster pr-24287 was deleted.

Rugvip
Rugvip requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 👍

Just some stability bits and needs a rebase, but otherwise good to go

.changeset/modern-hounds-give.md Outdated Show resolved Hide resolved
plugins/auth-backend/api-report.md Outdated Show resolved Hide resolved
Rugvip
Rugvip approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

Got a conflict to resolve before we're able to merge

@pjungermann
feat(auth): migrate Bitbucket auth provider to module package
ba763b6 
Migrate the Bitbucket auth provider to the new `@backstage/plugin-auth-backend-module-bitbucket-provider` module package.

Relates-to: backstage#19476
Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
@Rugvip Rugvip merged commit afe7409 into backstage:master Apr 16, 2024
36 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.26.0 release, scheduled for Tue, 14 May 2024.

This was referenced Apr 16, 2024
Open
Merged
@pjungermann pjungermann deleted the pjungermann/auth/bitbucket branch April 17, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pjungermann @Rugvip