-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export RelatedEntitiesCard
presets
#24311
base: master
Are you sure you want to change the base?
Conversation
Changed Packages
|
Uffizzi Ephemeral Environment - Virtual ClusterYour cluster
Access the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - nothing problematic as everything is just static.
935c1d3
to
129caa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really pollutes the "global" package space - can you put them on the RelatedEntitiesCard itself like RelatedEntitiesCard.asComponentEntities = asComponentEntities
etc? Or maybe export a export namespace RelatedEntitiesCard { export function ... }
?
ba8687a
to
9cba4b3
Compare
@freben changed it to |
9cba4b3
to
8c36c75
Compare
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
8c36c75
to
27ec21e
Compare
unstale |
27ec21e
to
1e2f142
Compare
Signed-off-by: David Weber <david.weber@w3tec.ch> Signed-off-by: David Weber <david.weber.schenker@gmail.com>
1e2f142
to
e12cadd
Compare
Hey, I just made a Pull Request!
By exporting the presets, we as a backstage plugin developer can reuse the defaults with the
RelatedEntitiesCard
.✔️ Checklist
Signed-off-by
line in the message. (more info)