Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export RelatedEntitiesCard presets #24311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dweber019
Copy link
Contributor

Hey, I just made a Pull Request!

By exporting the presets, we as a backstage plugin developer can reuse the defaults with the RelatedEntitiesCard.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@dweber019 dweber019 requested review from a team as code owners April 16, 2024 16:54
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Apr 16, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 16, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog plugins/catalog patch v1.21.0-next.3

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-24311 was successfully created. Learn more about Uffizzi virtual clusters
To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-24311 --kubeconfig=[PATH_TO_KUBECONFIG]
    After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-24311-c5034.uclusters.app.uffizzi.com

Copy link
Member

@tudi2d tudi2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - nothing problematic as everything is just static.

@dweber019 dweber019 force-pushed the fix/export-relation-presents branch from 935c1d3 to 129caa4 Compare April 27, 2024 10:49
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really pollutes the "global" package space - can you put them on the RelatedEntitiesCard itself like RelatedEntitiesCard.asComponentEntities = asComponentEntities etc? Or maybe export a export namespace RelatedEntitiesCard { export function ... }?

@dweber019 dweber019 force-pushed the fix/export-relation-presents branch 2 times, most recently from ba8687a to 9cba4b3 Compare May 8, 2024 19:48
@dweber019
Copy link
Contributor Author

@freben changed it to RelatedEntitiesCard.asComponentEntities = asComponentEntities. Hope it's correct.

@dweber019 dweber019 force-pushed the fix/export-relation-presents branch from 9cba4b3 to 8c36c75 Compare May 8, 2024 19:52
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 29, 2024
@dweber019 dweber019 force-pushed the fix/export-relation-presents branch from 8c36c75 to 27ec21e Compare May 30, 2024 19:26
@dweber019
Copy link
Contributor Author

unstale

@github-actions github-actions bot removed the stale label May 30, 2024
@dweber019 dweber019 force-pushed the fix/export-relation-presents branch from 27ec21e to 1e2f142 Compare June 9, 2024 16:19
Signed-off-by: David Weber <david.weber@w3tec.ch>
Signed-off-by: David Weber <david.weber.schenker@gmail.com>
@dweber019 dweber019 force-pushed the fix/export-relation-presents branch from 1e2f142 to e12cadd Compare June 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants