cli: Improve the migrate tooling #24375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: blam <ben@blam.sh>
…ful about the replacing Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
Changed Packages
|
|
Uffizzi Cluster |
|
needs api reports |
Signed-off-by: blam <ben@blam.sh>
freben
approved these changes
Apr 19, 2024
| @@ -15,45 +15,54 @@ | |||
| */ | |||
| import { BackstagePackageJson, PackageGraph } from '@backstage/cli-node'; | |||
| import chalk from 'chalk'; | |||
| import { resolve as resolvePath } from 'path'; | |||
| import { resolve as resolvePath, join } from 'path'; | |||
There was a problem hiding this comment.
Suggested change
| import { resolve as resolvePath, join } from 'path'; | |
| import { resolve as resolvePath, joinPath } from 'path'; |
just a common pattern
| import { OptionValues } from 'commander'; | ||
| import { readJson, writeJson } from 'fs-extra'; | ||
| import { minimatch } from 'minimatch'; | ||
| import { runYarnInstall } from './bump'; | ||
| import replace from 'replace-in-file'; | ||
|
|
||
| declare module 'replace-in-file' { |
Signed-off-by: blam <ben@blam.sh>
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
benjdlambert
added a commit
that referenced
this pull request
Apr 19, 2024
Signed-off-by: blam <ben@blam.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to do find and replace in the packages for the packages that have changed in the community migration.
This assumes that there's no breaking changes in the packages and is here to help smooth the migration process to the new namespaces.
This is kind of best effort, and we're hoping fixes most use cases 🤞