feat(catalog): add Link to tags and other fields in AboutCard #24445
Conversation
deshmukhmayur
requested review from
a team and
backstage-service
as code owners
Changed Packages
|
deshmukhmayur
force-pushed
the
feat-about-card-external-links
branch
from
aca571d
to
3a6d839
Compare
|
My bad. I think this should probably be a minor version bump, not a patch. Updated the changeset again. |
Uffizzi Ephemeral Environment - Virtual Cluster☁️ deploying cluster ⚙️ Updating now by workflow run 8785304417. Download the Uffizzi CLI to interact with the upcoming virtual cluster |
|
Hello, any update on this? |
There was a problem hiding this comment.
Thanks for the contribution @deshmukhmayur, over all this looks good but I'm deferring final say to the Maintainers. I did leave two comments though
| @@ -99,6 +103,16 @@ export function AboutContent(props: AboutContentProps) { | |||
| }); | |||
| const ownedByRelations = getEntityRelations(entity, RELATION_OWNED_BY); | |||
|
|
|||
| function getPathForFilter(filter: string, value: string) { | |||
There was a problem hiding this comment.
Best I can tell there is nothing that's actually testing this function, can we make sure to add tests for this, please?
There was a problem hiding this comment.
I see the existing unit tests only test for text content, so I didn't make any changes to that.
I'll try to add tests for the links and other functions.
Added a Link component to the tags, lifecycle and type fields in the AboutContent inside AboutCard. This makes the fields clickable and navigates the user to the catalog index page, with preselected filters. Signed-off-by: Mayur Deshmukh <deshmukhmayur@outlook.com>
deshmukhmayur
force-pushed
the
feat-about-card-external-links
branch
from
3a6d839
to
bb2a6dd
Compare
|
Ping @deshmukhmayur did you manage to get round to having a look at adding some tests? 🙏 |
|
Hey @benjdlambert , I got busy with other work so haven't had the chance to add the tests yet. Will work on it as soon as I get some time by next couple of weeks. |
Hey, I just made a Pull Request!
Added a Link component to the tags, lifecycle and type fields in the
AboutContentinsideAboutCard.This makes the fields clickable and navigates the user to the catalog index page, with preselected filters.
Resolves #24213
✔️ Checklist
Signed-off-byline in the message. (more info)