New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section to document how to create custom template filter #24451
base: master
Are you sure you want to change the base?
Conversation
PR can be reviewed :-) @benjdlambert @camilaibs |
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
…ckend System Signed-off-by: cmoulliard <cmoulliard@redhat.com>
48778c5
to
b10a8cb
Compare
message: ${{ parameters.userName | betterFilter | base64 }} | ||
``` | ||
|
||
### Register Custom Filters with the New Backend System |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should flip this around so that the new backend system
is referred to as the default, and theres a legacy backend system
section underneath too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I will flip the 2 sections then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about my refactoring ? 686e31b @benjdlambert
…nd at the end the legacy Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-by
line in the message. (more info)