Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section to document how to create custom template filter #24451

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cmoulliard
Copy link
Contributor

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 22, 2024
@cmoulliard cmoulliard marked this pull request as ready for review April 22, 2024 16:36
@cmoulliard cmoulliard requested review from a team as code owners April 22, 2024 16:36
@cmoulliard
Copy link
Contributor Author

cmoulliard commented Apr 23, 2024

PR can be reviewed :-) @benjdlambert @camilaibs

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
…ckend System

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
message: ${{ parameters.userName | betterFilter | base64 }}
```

### Register Custom Filters with the New Backend System
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should flip this around so that the new backend system is referred to as the default, and theres a legacy backend system section underneath too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I will flip the 2 sections then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about my refactoring ? 686e31b @benjdlambert

…nd at the end the legacy

Signed-off-by: cmoulliard <cmoulliard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants