Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaffolder: Redactions and keeping the log format #24478

Merged
merged 4 commits into from
Apr 23, 2024
Merged

scaffolder: Redactions and keeping the log format #24478

merged 4 commits into from
Apr 23, 2024

Conversation

benjdlambert
Copy link
Member

Fixes #23755 and #24144

@benjdlambert
chore: make sure to redact secrets in meta fields
8fa9cb6 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert
chore: fix redactions
93f2823 
Signed-off-by: blam <ben@blam.sh>
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Apr 23, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Apr 23, 2024 •
edited

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-app-api packages/backend-app-api patch v0.7.0
@backstage/plugin-scaffolder-backend plugins/scaffolder-backend patch v1.22.4

@benjdlambert
feat: reworking
5f0c46f 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert
chore: add changesets
025641b 
Signed-off-by: blam <ben@blam.sh>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited

Uffizzi Cluster pr-24478 was deleted.

freben
freben approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative yay

@benjdlambert benjdlambert marked this pull request as ready for review April 23, 2024 13:20
@benjdlambert benjdlambert merged commit 0f163a4 into master Apr 23, 2024
36 checks passed
@benjdlambert benjdlambert deleted the blam/scaffolder-logger-fox branch April 23, 2024 13:30
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.27.0 release, scheduled for Tue, 14 May 2024.

@kim-tsao
Copy link

kim-tsao commented May 2, 2024

@benjdlambert can this fix be backported to 1.26? It's a security issue that we would like to see closed.

@benjdlambert
Copy link
Member Author

@kim-tsao since this has been requested a few times, i'm putting it together now 🙏

benjdlambert added a commit that referenced this pull request May 2, 2024
@benjdlambert
Patch from PR #24478
6079afa 
Signed-off-by: blam <ben@blam.sh>
benjdlambert added a commit that referenced this pull request May 3, 2024
@benjdlambert
Merge pull request #24596 from backstage/patch-release-pr-24478
515310b 
Patch release of #24478
benjdlambert added a commit that referenced this pull request May 3, 2024
@benjdlambert
Patch from PR #24478
b6b59c5 
Signed-off-by: blam <ben@blam.sh>
benjdlambert added a commit that referenced this pull request May 3, 2024
@benjdlambert
Merge pull request #24609 from backstage/patch-release-pr-24478-24511
7d37192 
Patch release of #24478, #24511
@BethGriggs BethGriggs mentioned this pull request May 3, 2024
Merged
4 tasks
@Rugvip Rugvip mentioned this pull request May 11, 2024
Open
5 tasks
@floric floric mentioned this pull request May 21, 2024
Closed
2 tasks
@floric floric mentioned this pull request Jun 3, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@Rugvip Rugvip Awaiting requested review from Rugvip Rugvip is a code owner automatically assigned from backstage/maintainers

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

@acierto acierto Awaiting requested review from acierto acierto is a code owner automatically assigned from backstage/scaffolder-maintainers

Assignees
No one assigned
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: scaffolder-backend tasklogger does not respect log format
3 participants
@benjdlambert @kim-tsao @freben