Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add processor to send notifications to ms teams #24599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drodil
Copy link
Contributor

@drodil drodil commented May 2, 2024

Hey, I just made a Pull Request!

A new processor that can be used to send notifications to Microsoft Teams webhooks. The webhook must be either entity annotation or for broadcast in the configuration.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@drodil drodil requested review from a team and backstage-service as code owners May 2, 2024 19:07
@drodil drodil requested a review from Rugvip May 2, 2024 19:07
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 2, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-notifications-backend-module-email plugins/notifications-backend-module-email patch v0.1.0
@backstage/plugin-notifications-backend-module-teams plugins/notifications-backend-module-teams patch v0.0.0
@backstage/plugin-notifications-node plugins/notifications-node patch v0.2.0

Copy link
Contributor

github-actions bot commented May 2, 2024

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-24599 was successfully created. Learn more about Uffizzi virtual clusters
To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-24599 --kubeconfig=[PATH_TO_KUBECONFIG]
    After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-24599-c5372.uclusters.app.uffizzi.com

@drodil drodil force-pushed the teams_notification_processor branch from 904b2a7 to 370aa73 Compare May 2, 2024 19:22
@drodil
Copy link
Contributor Author

drodil commented May 2, 2024

The absolute link utility is the same as here #24555 which needs refactoring once this is merged.

@drodil drodil force-pushed the teams_notification_processor branch 3 times, most recently from 4db138c to a60ecaf Compare May 2, 2024 19:40
@drodil drodil force-pushed the teams_notification_processor branch 4 times, most recently from adff1a7 to c3c6340 Compare May 3, 2024 02:48
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 29, 2024
@drodil
Copy link
Contributor Author

drodil commented May 29, 2024

Not stale, @mareklibra chance to review?

@github-actions github-actions bot removed the stale label May 29, 2024
Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run it but code-wise it lgtm.

@drodil drodil force-pushed the teams_notification_processor branch from c3c6340 to f107c73 Compare May 31, 2024 06:30
@drodil
Copy link
Contributor Author

drodil commented May 31, 2024

Rebased

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jun 14, 2024
@drodil
Copy link
Contributor Author

drodil commented Jun 14, 2024

Not stale

@github-actions github-actions bot removed the stale label Jun 14, 2024
@mareklibra
Copy link
Contributor

@drodil Let's merge it when the Ci is green.

@drodil drodil force-pushed the teams_notification_processor branch 2 times, most recently from 633215e to af92062 Compare June 20, 2024 05:58
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
@drodil drodil force-pushed the teams_notification_processor branch from af92062 to b1c6b4d Compare June 20, 2024 06:14
@drodil
Copy link
Contributor Author

drodil commented Jun 20, 2024

@mareklibra we are green!

@mareklibra
Copy link
Contributor

The yarn.lock change prevents me to do the merge, we need backstage/maintainers here. Cc @freben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants