Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Docs Project Area #24657

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Added Docs Project Area #24657

merged 3 commits into from
Jun 28, 2024

Conversation

awanlin
Copy link
Collaborator

@awanlin awanlin commented May 6, 2024

Hey, I just made a Pull Request!

Added the Documentation Project Area with @aramissennyeydd, @waldirmontoya25, and myself as initial members

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin awanlin requested review from a team as code owners May 6, 2024 17:40
@awanlin awanlin requested review from Rugvip and camilaibs May 6, 2024 17:40
aramissennyeydd
aramissennyeydd approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@aramissennyeydd aramissennyeydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this up!

OWNERS.md Outdated Show resolved Hide resolved
Rugvip
Rugvip reviewed May 17, 2024
View reviewed changes
OWNERS.md Outdated
| -------------- | ------------ | ----------------------------------------------------- | ----------------- |
| Andre Wanlin | Spotify | [awanlin](https://github.com/awanlin) | `ahhhndre` |
| Aramis Sennyey | | [aramissennyeydd](https://github.com/aramissennyeydd) | `Aramis#7984` |
| Waldir Montoya | Broadcom | [waldirmontoya25](https://github.com/waldirmontoya25) | `waldirmontoya25` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could skip Waldir for now if you want to ship this sooner?

@joshjung
Copy link
Contributor

I would like to be added to this, per our discussions @Rugvip and @ahhhndre. You can put my company as Vail Systems.

@aramissennyeydd aramissennyeydd mentioned this pull request May 29, 2024
Open
5 tasks
@Parsifal-M
Copy link
Collaborator

Happy to be added (@aramissennyeydd, thanks!) you can add me as part of VodafoneZiggo 👍

@awanlin
Copy link
Collaborator Author

awanlin commented May 29, 2024

Following up that I'll be working on updating this on this Friday 👍

@awanlin
Copy link
Collaborator Author

awanlin commented May 29, 2024

Hi @joshjung, I'm happy to add you in a follow up PR. Currently you need to be an active Org Member to be part of a Project Area. Given how early stages we are with this not being part of the project area won't really impact you. There's lots of decisions and thinkings that need to be done that you can actively take part in. 👍

@awanlin
Copy link
Collaborator Author

awanlin commented Jun 8, 2024

Hi @Parsifal-M, I was finally getting back to this and it seems you aren't an Org Member yet either, you need to be one to be part of a Project Area. You can still take part in SIGs though. You might already meet the requirements, can you apply, please? Once that's done I can add you.

@Parsifal-M
Copy link
Collaborator

Hi @Parsifal-M, I was finally getting back to this and it seems you aren't an Org Member yet either, you need to be one to be part of a Project Area. You can still take part in SIGs though. You might already meet the requirements, can you apply, please? Once that's done I can add you.

Ah clear! Will do that on Monday, no worries!

@awanlin
Copy link
Collaborator Author

awanlin commented Jun 19, 2024

Updated this PR, I'm assuming that this will be pending approval of this Org Member request.

@awanlin
Added Docs Project Area
e5b5e08 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Updates
a8d0b87 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Updates
8def8fe 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Copy link
Collaborator Author

awanlin commented Jun 28, 2024

@Parsifal-M now that you are an Org Member can you approve this, please?

Parsifal-M
Parsifal-M approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@Parsifal-M Parsifal-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏

@awanlin awanlin requested a review from Rugvip June 28, 2024 20:54
freben
freben approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

@freben freben merged commit 2bb2a6d into backstage:master Jun 28, 2024
21 checks passed
@awanlin awanlin deleted the topic/add-docs-sig branch June 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben approved these changes

@Parsifal-M Parsifal-M Parsifal-M approved these changes

@aramissennyeydd aramissennyeydd aramissennyeydd approved these changes

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

@Rugvip Rugvip Awaiting requested review from Rugvip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@awanlin @joshjung @Parsifal-M @freben @Rugvip @aramissennyeydd