-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: remove custom fallback #24838
Merged
vinzscam
merged 4 commits into
backstage:master
from
elaine-mattos:fix/gitlab-ingestion-fallback-branch
May 24, 2024
Merged
Bugfix: remove custom fallback #24838
vinzscam
merged 4 commits into
backstage:master
from
elaine-mattos:fix/gitlab-ingestion-fallback-branch
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Changed Packages
|
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Closed
2 tasks
vinzscam
approved these changes
May 21, 2024
vinzscam
reviewed
May 21, 2024
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com> Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
2 tasks
Hi @vinzscam , are there any other approvals that are still needed for this one to be merged as well? :) |
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Uffizzi Cluster |
vinzscam
added a commit
that referenced
this pull request
May 24, 2024
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes an introduced bug where the fallback branch was taking precedence over the GitLab project's default branch.
This fixes #24825
✔️ Checklist
Signed-off-by
line in the message. (more info)