Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: remove custom fallback #24838

Merged

Conversation

elaine-mattos
Copy link
Contributor

@elaine-mattos elaine-mattos commented May 20, 2024

Hey, I just made a Pull Request!

Fixes an introduced bug where the fallback branch was taking precedence over the GitLab project's default branch.
This fixes #24825

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label May 20, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented May 20, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-backend-module-gitlab plugins/catalog-backend-module-gitlab patch v0.3.16

Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Elaine Mattos <elaine.mattos@gmail.com>
@elaine-mattos
Copy link
Contributor Author

Hi @vinzscam ,

are there any other approvals that are still needed for this one to be merged as well? :)

@vinzscam vinzscam merged commit 09c05a1 into backstage:master May 24, 2024
28 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

Copy link
Contributor

Uffizzi Cluster pr-24838 was deleted.

vinzscam added a commit that referenced this pull request May 24, 2024
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
benjdlambert added a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: 1.27 GitLab discovery regression when using fallbackBranch other than master
2 participants