Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization of shadowRoot state. #25240

Closed
wants to merge 6 commits into from
Closed

Add serialization of shadowRoot state. #25240

wants to merge 6 commits into from

Conversation

squid-ney
Copy link
Contributor

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@github-actions github-actions bot added the area:techdocs Related to the TechDocs Project Area label Jun 14, 2024
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jun 14, 2024 •
edited
Loading

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage/plugin-techdocs-react
  • @backstage/plugin-techdocs

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-techdocs-react plugins/techdocs-react none v1.2.5
@backstage/plugin-techdocs plugins/techdocs none v1.10.6

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

github-actions bot and others added 6 commits June 19, 2024 14:48
@github-actions @squid-ney
Version Packages (next)
0e7a41f 
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
@squid-ney
Add serialization of shadowRoot state.
06c09d1 
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
@squid-ney
Update provider shadow root logic
4b96c08 
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
@squid-ney
Use versioned approach to resolve shadowRoot not updating issues
1e05c71 
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
@squid-ney
Cleanup
835e60d 
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
@squid-ney
remove querySelector
def42f1 
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation area:catalog Related to the Catalog Project Area auth area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. search Things related to Search homepage Features for the composable homepage area:scaffolder Everything and all things related to the scaffolder project area area:permission Related to the Permission Project Area area:discoverability Related to the Discoverability Project Area area:events Related to the Events Project Area labels Jun 19, 2024
@squid-ney squid-ney closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awanlin awanlin Awaiting requested review from awanlin awanlin will be requested when the pull request is marked ready for review awanlin is a code owner

@pjungermann pjungermann Awaiting requested review from pjungermann pjungermann will be requested when the pull request is marked ready for review pjungermann is a code owner

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service will be requested when the pull request is marked ready for review backstage-service is a code owner

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area area:discoverability Related to the Discoverability Project Area area:events Related to the Events Project Area area:kubernetes Related to the Kubernetes Project Area - not deploying Backstage with k8s. area:permission Related to the Permission Project Area area:scaffolder Everything and all things related to the scaffolder project area area:techdocs Related to the TechDocs Project Area auth documentation Improvements or additions to documentation homepage Features for the composable homepage search Things related to Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@squid-ney