[NBS1.0] Deprecate database manager from commons package #25257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
camilaibs
changed the title
6 tasks
camilaibs
force-pushed
the
camilaibs/nbs10-deprecate-database-common-impl
branch
2 times, most recently
from
5889127
to
c466a76
Compare
camilaibs
commented
Jun 15, 2024
| * @public | ||
| * @deprecated Use `DatabaseManager` from the `@backstage/backend-defaults` package instead | ||
| */ | ||
| export class DatabaseManager implements LegacyRootDatabaseService { |
There was a problem hiding this comment.
Note
I could not extends the _DatabaseManager class as its constructor is private and could not assign it to constant because constants cannot be used as a class type.
There was a problem hiding this comment.
What happens when you do the export const X = _X style? I think we're already doing that in several places. Do we need to fix those?
There was a problem hiding this comment.
I start getting the error of constants cannot be used as type:
There was a problem hiding this comment.
I believe the error only happens to classes because they can be used both as value and type...
camilaibs
force-pushed
the
camilaibs/nbs10-deprecate-database-common-impl
branch
2 times, most recently
from
baa8a48
to
9f519be
Compare
github-actions
bot
added
storybook
camilaibs
force-pushed
the
camilaibs/nbs10-deprecate-database-common-impl
branch
from
dc7c256
to
f8c5bee
Compare
github-actions
bot
removed
storybook
github-actions
bot
removed
microsite
|
rebase needed though! |
Signed-off-by: Camila Belo <camilaibs@gmail.com>
camilaibs
force-pushed
the
camilaibs/nbs10-deprecate-database-common-impl
branch
from
f8c5bee
to
ed3074e
Compare
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Ref: #25148
The
DatabaseServicetypes and implementations were extracted to the package@backstage/backend-defaultsand deprecated from@backstage/backend-commons. This change is a preparation for the New Backend System stable release.✔️ Checklist
Signed-off-byline in the message. (more info)