move react types to a dev dependency and peer dependency #25307
+1,260
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:catalog
Changed Packages
|
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
aramissennyeydd
force-pushed
the
react-types-peer-dependencies
branch
from
afdcf87
to
7fdad4a
Compare
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
aramissennyeydd
requested review from
a team,
awanlin and
backstage-service
as code owners
Signed-off-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
|
Wanna bring in @Rugvip here too, although he's out on vacation at the minute for a few weeks. 🙏 |
2 tasks
acierto
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes #25278. There's been prior work in this space, (#8361, #22539, 482bb5c and #17116), but I think we've flip-flopped a bit between the types being a peer dependency and a full dependency.
Ideally, they should be both a dev dependency and a peer dependency, so they can be installed and used locally for development, but adopters can provide a custom version - possibly a different major version. For package managers using
peerDependenciesMeta, I also listed the types as an optional dependency as they are not required to consume the package. This is generally standard, example from MUI.I also added this as a required CI check. As part of that, I required all peer dependencies that are defined to be installed in dev dependencies. IMO that's how they should be setup unless the peer dependency isn't actually needed.
✔️ Checklist
Signed-off-byline in the message. (more info)