Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only bootstrap global-agent in the CLI if it's actually being used #25319

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Only bootstrap global-agent in the CLI if it's actually being used #25319

merged 2 commits into from
Jun 19, 2024

Conversation

freben
Copy link
Member

@freben freben commented Jun 19, 2024 •
edited
Loading

@freben freben requested review from backstage-service and a team as code owners June 19, 2024 12:46
@freben freben force-pushed the freben/destroy branch 3 times, most recently from a48972c to bd763d0 Compare June 19, 2024 14:43
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jun 19, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.26.7

@freben
try to debug the _a.destroy problem
96be5d1 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@freben
fix the _a.destroy test flakiness
7652db4 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
@freben freben changed the title try to debug the _a.destroy problem Only bootstrap global-agent in the CLI if it's actually being used Jun 19, 2024
benjdlambert
benjdlambert approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@benjdlambert benjdlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could move the function out of the bump script perhaps, but happy either way.

@freben
Copy link
Member Author

freben commented Jun 19, 2024

Myeah might move it somewhere more global later

@freben freben merged commit 08a6bd7 into master Jun 19, 2024
33 checks passed
@freben freben deleted the freben/destroy branch June 19, 2024 18:40
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.29.0 release, scheduled for Tue, 16 Jul 2024.

@freben freben mentioned this pull request Jun 19, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freben @benjdlambert