feat(apidocs): add resolvers prop to AsyncApiDefinitionWidget #25325
+162
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Stamm <simon.stamm@tui.com>
Changed Packages
|
|
@vinzscam Sorry for the ping, any chance you could take a quick look at this? It's just an additional feature, nothing will change. Thank you very much! |
vinzscam
requested changes
Jul 1, 2024
plugins/api-docs/src/components/AsyncApiDefinitionWidget/AsyncApiDefinition.tsx
Outdated
Show resolved
Hide resolved
plugins/api-docs/src/components/AsyncApiDefinitionWidget/AsyncApiDefinition.tsx
Show resolved
Hide resolved
| const classes = useStyles(); | ||
| const theme = useTheme(); | ||
| const classNames = `${classes.root} ${ | ||
| theme.palette.type === 'dark' ? classes.dark : '' | ||
| }`; | ||
|
|
||
| // Overwrite default resolvers if custom ones are set | ||
| if (resolvers) { | ||
| config.parserOptions.__unstable.resolver.resolvers = resolvers; |
There was a problem hiding this comment.
does it make sense to cover the case where someone wants to add an extra resolver to the default ones?
There was a problem hiding this comment.
I have also thought about this case, but which should be additional protocols to http and https. So I made it easier by overriding it.
…tion component Signed-off-by: Simon Stamm <simon.stamm@tui.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This adds
resolversprop toAsyncApiDefinitionWidgetwhich allows to override the default http/https resolvers, for example to add authentication to requests to internal schema registries.✔️ Checklist
Signed-off-byline in the message. (more info)