Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide NotificationsPage toolbar for empty list #25337

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

mareklibra
Copy link
Contributor

Hey, I just made a Pull Request!

On the NotificationsPage, the Select All checbox and mass-action buttons are hidden for empty data set.
Prior this change, the components were disabled but present which did not look nice.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Marek Libra <marek.libra@gmail.com>
@mareklibra mareklibra requested review from a team as code owners June 20, 2024 08:26
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-notifications plugins/notifications patch v0.2.2

@mareklibra
Copy link
Contributor Author

Before:

Screenshot from 2024-06-20 10-21-35


After:

Screenshot from 2024-06-20 10-21-10

@mareklibra
Copy link
Contributor Author

@freben Can you please have a look?

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks a bit odd with the double horizontal lines but it's still an improvement

@freben freben merged commit c780320 into backstage:master Jun 29, 2024
25 checks passed
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.29.0 release, scheduled for Tue, 16 Jul 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants