Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update extension for jsx code snippets file #25342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CaioAugustoo
Copy link
Contributor

@CaioAugustoo CaioAugustoo commented Jun 20, 2024

Hey, I just made a Pull Request!

On Sub Route References docs some code snippets are using .ts extension instead of .tsx. This is incorrect because those code snippets are using JSX with TypeScript. If anyone try to copy and paste the snippet inside an IDE it will throw an error.

E.g:
image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Caio Augusto <caioamfr@gmail.com>
…jsx-snippets

fix(docs): update extension for jsx code snippets file
@CaioAugustoo CaioAugustoo requested review from a team as code owners June 20, 2024 13:28
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 20, 2024
Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @CaioAugustoo 👍

@CaioAugustoo
Copy link
Contributor Author

Thank you @awanlin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants